koderover / zadig

Zadig is a cloud native, distributed, developer-oriented DevOps platform
https://koderover.com
Other
2.74k stars 820 forks source link

More richable feishu notification #33

Closed KevinWu0904 closed 2 years ago

KevinWu0904 commented 3 years ago

/kind enhancement

Currently, feishu supports more richable bot notification. Refer to : https://open.feishu.cn/document/ukTMukTMukTM/uMDMxEjLzATMx4yMwETM?op_tracking=hc.

Maybe we can improve this point.

lilianzhu commented 3 years ago

Regarding the feishu notification , what are the specific requirements here? Maybe the notification message requires @specified person?

KevinWu0904 commented 3 years ago

It's necessary to add test details to the notification. For example:

  1. Passed/Failed/Skipped number
  2. Code coverage

And maybe we can take advantage of feishu message cards' color. Red for failed pipeline, green for passed pipeline.

Just my rough suggestions.

landylee007 commented 3 years ago

It's necessary to add test details to the notification. For example:

  1. Passed/Failed/Skipped number
  2. Code coverage

And maybe we can take advantage of feishu message cards' color. Red for failed pipeline, green for passed pipeline.

Just my rough suggestions.

👍 Great suggestion, we will open source code of test management parts and evaluate the improvements.

flyer103 commented 2 years ago

Hi @KevinWu0904 , the feature request has been resolved in https://github.com/koderover/zadig/pull/904 and will be released in version 1.9.0 :D

landylee007 commented 2 years ago

It has been released in v1.9.0 . 😊