search

kodi-adsp / adsp.biquad.filters

Biquad filter addon for Kodi's AudioDSP-System
GNU General Public License v3.0
3 stars 10 forks source link

Typos? #12

Open MilhouseVH opened 8 years ago

MilhouseVH commented 8 years ago

Could of minors:

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L1 - should be asplib, not libsamplerate - it's a little confusing for us cmake noobs. :)

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L14 - why does this file have the prefix apslib and all the others are asplib? I'm assuming it's a typo, although the file does actually exist with the apslib prefix...

MilhouseVH commented 8 years ago

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L26 SAMPLERATE_FOUND

AchimTuran commented 8 years ago

@MilhouseVH Sorry for the late response, but I didn't had the time to look deeper into it.

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L14 - why does this file have the prefix apslib and all the others are asplib? I'm assuming it's a typo, although the file does actually exist with the apslib prefix...

find_path(ASPLIB_INCLUDE_DIRS "apslib_BiquadFactory.h" should be find_path(ASPLIB_INCLUDE_DIRS " "Biquads/apslib_BiquadFactory.h". All files of asplib should have the prefix asplib.

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L26 SAMPLERATE_FOUND https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L1 - should be asplib, not libsamplerate - it's a little confusing for us cmake noobs. :)

Yeah you're right. It should be asplib and not libsamplerate. That was one of my first CMake files and I was so happy that it worked and I didn't improve the copy and paste comments ;-)

All of this will be fixed in the next release of asplib. Thanks for the hints.