kodi-community-addons / plugin.audio.squeezebox

Squeezelite player for Kodi
GNU General Public License v2.0
15 stars 7 forks source link

Argument "-C 1" is not supported by 'squeezelight' client on ARM-targets #1

Open hoxi opened 6 years ago

hoxi commented 6 years ago

In the file 'resources/lib/main_service.py' the following line sends the argument "-C 1" to the 'squeezelite' client. line 205: args = [sl_binary, "-s", self.lmsserver.host, "-a", "80", "-C", "1", "-m",

This argument is not supported by squeezelite, and should probably be removed for ARM-targets (or changed if the intention was something else?)

marcelveldt commented 6 years ago

Are you sure about that ? It should be a valid option for recent squeezelite versions

hoxi commented 6 years ago

Well, maybe I have somehow received a very old version then? I installed the squeezebox plugin via the repository.marcelveldt-1.0.1.zip and are executing the squeezelight that is placed under the squeezebox plugin directory: /home/xbian/.kodi/addons/plugin.audio.squeezebox/resources/lib/bin/linux/squeezelite-arm -C 2 Option error: -C Squeezelite v1.7.1-532, Copyright 2012-2015 Adrian Smith. See -t for license terms I can see now that later versions of squeezelite indeed supports the -C flag, but maybe the plugin bundled version is to old for the linux/arm target then?

marcelveldt commented 6 years ago

hmmm, oops. In that case I must update the bundled squeezelite binaries. I guess I never payed too much attention to the arm versions. Thanks for the tip, I'll put a fix in place.