search

kodi-community-addons / skin.titan

http://forum.kodi.tv/forumdisplay.php?fid=212
GNU General Public License v2.0
29 stars 23 forks source link

[krypton] skin items #227

Closed mgonzales71 closed 7 years ago

mgonzales71 commented 8 years ago

noticed a few Krypton related items - created this Issue to help track the ones I have noticed (and have not but you may have?) :smile:

anyway - I am sure there are others - just added the ones I noticed while testing the latest kodi krypton alpha + titan skin (beta)

mgonzales71 commented 8 years ago

Hey Marcel,

Hope you and your family are doing well

Decided to take a crack at DialogPlayerProcessInfo.xml

http://pastebin.com/DTfYUnub (updated 8/10 with small change in panel bg size)

Also IncludesVariables.xml needs the following added:

     <variable name="VideoHWDecoder">
        <value condition="Player.Process(videohwdecoder)">Hardware</value> <!-- localize string -->
        <value>Software</value> <!-- localize string -->
     </variable>

Note:

Right now lables are hard coded english since I haven't yet searched for existing localized string values (or added missing ones) - that's why I put all those "" in as a reminder.

Couple of screenshots (used DemoPVR since I don't have a tuner/dvr):

2016-08-10_04-10-31

2016-08-10_04-10-39

Not sure about the use of buttons with the -5 item gap - was trying to go for a "tab" look.. plus I wanted to try out the new auto width :smile:

let me know what you think.

Thanks,

Mario

mgonzales71 commented 8 years ago

2016-08-10_04-30-27

(forgot a screenshot - this shows movie playback with the playerprocessinfo, plot and info display visible)

marcelveldt commented 8 years ago

Hi Mario! Yes, all doing great here. Having our holidays now so just enjoying the quality time with the family. Hopefully the weather will be better next days because so far it was not that great.

You're also doing fine ?

Thanks for your work on this! Would it be possible to do a PR for this on the Krypton branch ? If not I'll merge in the changes myself.

The language ID's to use can be found in the language resource addon, with hardcoded strings the repo submission will be denied. If you do not have time for the language ID's I'll take a look at it myself next week.

mgonzales71 commented 8 years ago

I just upgraded my windows 10 to the big anniversary update and it broke my SourceTree / GitHub environment - I am going to work on getting that back up and working today and then I can manage PR's etc

And I know about the language ID's that is why I placed all those reminder comments so I knew where to update the code when I had time to search the Kodi built in ID's and then add the missing ones to the skin.

Yea - doing well here also :smile: glad that you are too!

Awww yes - I am guessing you mean "holiday(s)" (in European sense) he he

Over here when everyone at work is off for a day(s) it's a "holiday" but if you are off but most everyone else has to work that is a "vacation" - and we get a lot less "vacation" then most of the more "advanced" nations of the world LOL I am jealous!

Well have fun - hope you get some good weather - it's been HOT here the last couple weeks after a nice mild July - I am already tired of the 90+ :fire: temps here.

If all goes well I should get you a PR in a day or so.

Mario

marcelveldt commented 8 years ago

Yes, it's vacation indeed. I have 3 weeks of vacation this year. Already 2 weeks have passed and the weather was really crap. lot's of rain and cold temperatures. Luckily since yesterday the rain stopped and the temperature is rising above the 20 degrees celcius.

Hope you can get your system running again. I plan to fix the latest Krypton changes in next couple of days.

Thanks as always for your help.

mgonzales71 commented 8 years ago

Got the PR done for DialogPlayerProcessInfo - https://github.com/marcelveldt/skin.titan/pull/229

marcelveldt commented 8 years ago

the addon.xml is now updated for krypton, also incorporated the new changes to the addoninfo dialog. only thing todo some day is create some new screenshots (in master branch) because the current ones are really outdated

mgonzales71 commented 8 years ago

i saw that - very nice!

once the skin has stabelized and kryton is at least to RC stage it probably will be safe to add new screenshots then!

I had a suggestion for changes to "settings" for the skin since so much has changed for Krypton.

Something like the following (would make touch users happy with larger targets)

ALSO something I didn't mock up but will also suggest is that sub menu settings buttons of the main settings icons buttons be increased in "height" for the same reason (touch users):

icons replacing current background (well landscape image):

2016-08-19_17-16-56

or making the existing (or new) landscape image a fullscreen background in addition the icon buttons:

2016-08-19_17-16-56 a

mgonzales71 commented 8 years ago

Marcel,

was playing around with a new skin "Theme" (as in textures)

here is the xbt file for the one I have been playing around with - goal is to add a little subtle "texture" to the textures in the skin LOL

more of a WIP for fun thing I was doing for personal amusement but curious what you think

https://onedrive.live.com/redir.aspx?cid=599da6bd82779e65&resid=599DA6BD82779E65!7466&parId=599DA6BD82779E65!4605&authkey=!AJlacGJOzfy1zps&ithint=file%2cxbt

FYI - based off textures for krypton rev of the skin

mario