add fallback(s) for $VAR VideoPlayerClearArt

[mgonzales71]

This PR is just a proposed work around (you can decline and it won't bother me 😄 hehe)

PR: add fallback(s) for $VAR VideoPlayerClearArt for OSD display.

reason for PR: i don't think you can do an is empty check on a $VAR - so figured this could be a workaround to display something when setting is enabled...

thoughts?

Also Related Question...

in DialogSeekbar.xml the visibility condition for this image control has "!Control.IsVisible(552233)" - should that be omitted?

[marcelveldt]

Displaying the poster instead of the clearart is not a very good option imo. users will expect the clearart (because the setting is called like that). If it's not available it should just be empty.

BTW: I think the OSD panels need more work because the artwork is just floating around here and there on the screen. Clearart would look much better if it sits on top of the panel while the clearlogo will look better in the top panel

[mgonzales71]

actually - your logic makes sense due to the actual setting name (clearart).

In the VAR section where the artwork is set... I don't think you can invoke a runscript as one of the conditions to return a texture found by the helper script (can you?)

maybe in dialogseekbar.xml a conditional onload runscript if the $VAR[VideoPlayerClearArt] is empty to set it?

you know most of the time the actual image is local already even - so matching the library info for the playing episode and then checking for a local texture (by Kodi itself or just setting a property) could save a lot of headaches...

anyway - just throwing out ideas - would love someone to finally solve this issue :-)

thoughts?

[mgonzales71]

@marcelveldt

So - I noticed that almost always that $INFO[VideoPlayer.IMDBNumber] is populated with the correct IMDB # for the playing TV Show.

Any easy way to translate that into missing cleaart/clearlogo?

[marcelveldt]

If you've enabled lookups for addons in the skinsettings it will provide the missing artwork in the window properties.

[mgonzales71]

I am guessing the add on I am using is not compatible or something because I do have lookups enabled for add ons. is that setting dependent on any other settings?

[mgonzales71]

I am not sure if you have noticed the top bar with the plot, etc from DialogSeekBar will hide the clearart (it will only flash visible for a moment sometimes)..

As quick test I removed the 2 control based conditionals for visibility and it would display under what I am guessing is the textbox for the plot. Did not yet dig too much into this. Reducing the width of the plot text and finding out which of the 2 controls in the conditional visibility is causing the non-display when setting is set and artwork is available prob will fix it.

It sounded like you had a redesign in mind for dealing with artwork from an earlier message here or on Trello so I will close this for now.