Closed jose1711 closed 8 years ago
Running this one through a beautifier too would be great.
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.
_lib/server/mojevideosk.py, line 32 [r1] (raw file):_
def supports(url): return re.search(r'mojevideo\.sk', url) is not None
We don't support all the URLs on mojevideo.sk
, do we ? I suggest using something more like mojevideo\.sk/video/\w+/.+\.html
, just to make sure we only process pages which contain videos.
lib/server/mojevideosk.py, line 41 [r1] (raw file):
data=util.request(url) except: return None
I don't think we need this try/except. If you want to check, whether the response is correct or not, you should rather check if the latter re.search()
actually matched something.
_Comments from Reviewable_
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.
_lib/server/mojevideosk.py, line 32 [r1] (raw file):_
Done.
_lib/server/mojevideosk.py, line 41 [r1] (raw file):_
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
This change is