kodi-czsk / script.module.stream.resolver

3 stars 25 forks source link

Add support for mojevideo.sk #36

Closed jose1711 closed 8 years ago

jose1711 commented 8 years ago

This change is Reviewable

lubo commented 8 years ago

Running this one through a beautifier too would be great.


Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


_lib/server/mojevideosk.py, line 32 [r1] (raw file):_


def supports(url):
    return re.search(r'mojevideo\.sk', url) is not None

We don't support all the URLs on mojevideo.sk, do we ? I suggest using something more like mojevideo\.sk/video/\w+/.+\.html, just to make sure we only process pages which contain videos.


lib/server/mojevideosk.py, line 41 [r1] (raw file):

        data=util.request(url)
    except:
        return None 

I don't think we need this try/except. If you want to check, whether the response is correct or not, you should rather check if the latter re.search() actually matched something.


_Comments from Reviewable_

jose1711 commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


_lib/server/mojevideosk.py, line 32 [r1] (raw file):_

Previously, Kuci (Ľubomír Kučera) wrote… > We don't support all the URLs on `mojevideo.sk`, do we ? I suggest using something more like `mojevideo\.sk/video/\w+/.+\.html`, just to make sure we only process pages which contain videos. >

Done.


_lib/server/mojevideosk.py, line 41 [r1] (raw file):_

Previously, Kuci (Ľubomír Kučera) wrote… > I don't think we need this try/except. If you want to check, whether the response is correct or not, you should rather check if the latter `re.search()` actually matched something. >

Done.


Comments from Reviewable

lubo commented 8 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable