search

kodi-game / controller-topology-project

The Controller Topology Project models how controllers connect to and map to each other for all gaming history
Open Data Commons Open Database License v1.0
21 stars 15 forks source link

Add "Analog" button to PS controllers #226

Closed garbear closed 1 year ago

garbear commented 1 year ago

Description

As title says, this PR adds another button to the PS Dual Analog and PS Dualshock controllers.

The reason is to allow the PS4 controller to map the center PS button. Currently, the only way to map it is using the default profile because it has the Guide button. However, making the Analog button mappable means that PS4 controllers can be mapped to PS profiles.

The Analog button doesn't actually give any input in games, but it allows translation of the button to Guide in the GUI.

Motivation and context

I wanted to map the middle PS button on my PS4 controller, and realized that both images show a middle button that we could easily map:

PS Dual Analog

PS Dualshock

How has this been tested?

Produced the following screenshot:

Screenshot from 2023-02-22 20-34-45

garbear commented 1 year ago

@KOPRajs look good?

KOPRajs commented 1 year ago

I don't see any problem with that, looks good. We just need to think about it when creating the default translation mapping. Should I wait with the creating of the "codex" mapping for a build with this included?

garbear commented 1 year ago

Yes, lets get this in so that it's included in the codex