search

kodi-game / controller-topology-project

The Controller Topology Project models how controllers connect to and map to each other for all gaming history
Open Data Commons Open Database License v1.0
21 stars 15 forks source link

Sync of addon metadata translations #91

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

Sync of addon metadata translations triggered by cc262b9f284161312cb0f8e693ca808ac6f5c186

gade01 commented 3 years ago

@garbear Hmm.. this PR doesn't seem correct as well. The workflow added two && https://github.com/kodi-game/controller-topology-project/pull/91/files#diff-f95b21aa2bd730bbead4194e7f130e0df5a9b9dbfa11b1ecd947bbf21966adf8R16-R18

garbear commented 3 years ago

Ready to go?

gade01 commented 3 years ago

@garbear Still doesn't look correct with two && added several places: https://github.com/kodi-game/controller-topology-project/pull/91/files#diff-f95b21aa2bd730bbead4194e7f130e0df5a9b9dbfa11b1ecd947bbf21966adf8R17

garbear commented 3 years ago

Huh, that's weird because the strings in strings.po look good with an unescaped &. Do you know where the double-escaping in the XML could be taking place?

gade01 commented 3 years ago

It must be something with the script and the new commits. I know @anxdpanic will look into it when he has time.

garbear commented 3 years ago

@anxdpanic Do you have time to look into this?

anxdpanic commented 3 years ago

I am hoping to this weekend

garbear commented 3 years ago

@anxdpanic I'm going to merge and fixup everything by hand. We'll see if changes to the workflow are still needed for the new state of files

garbear commented 3 years ago

Merged and committed a fixup: https://github.com/kodi-game/controller-topology-project/commit/55d7c099f37599c5bf42f86135b0332d91098d46