search

kodi-game / game.libretro.pcsx-rearmed

PCSX ReARMed game client for XBMC
https://github.com/libretro/pcsx_rearmed
4 stars 11 forks source link

Fix missing settings #20

Closed garbear closed 3 years ago

garbear commented 3 years ago

Description

In this core, certain settings are disabled at compile-time. Because we generate settings on one machine for all platforms, let's just include settings for all platforms. This is the "quick and easy solution" mentioned in https://github.com/kodi-game/game.libretro.pcsx-rearmed/issues/19. My justification is that libretro settings are presented in the Kodi UI as "Advanced settings", so it's expected that the user would understand that changing a setting for a different system would have no effect.

How has this been tested?

I applied the patch, and then kodi-game-scripting generated the settings and language file here.

KOPRajs commented 3 years ago

It might have failed because of strict checking of "defined but not used".

Anyway you are missing some more ifdefs for the NEW_DYNAREC (and maybe others).

EDIT: Also we don't need to force GPU_PEOPS as it is enabled by the build platform and this is a hack anyway.

garbear commented 3 years ago

Superseded by https://github.com/kodi-game/game.libretro.pcsx-rearmed/pull/21