search

kodi-game / game.libretro.picodrive

Picodrive for Kodi
https://github.com/libretro/picodrive
1 stars 5 forks source link

Controller topology #8

Closed KOPRajs closed 9 months ago

KOPRajs commented 10 months ago

This PR adds:

The 3 button controller lets you use the new default button map (X, A, B instead of A, B, R1).

To use more than 2 players you need to set the Teamplayer or 4wayplay in the advanced emulator settings as Input 1. I've looked through the Picodrive's libretro frontend source code and it seems that 4 players are maximum that is supported.

The icon is one that I've made for my personal use several years back when there was no icon for this add-on at all. Unlike Genesis Plus GX the Picodrive has the ability to emulate Sega 32X system, hence the picture shows the console with the 32X add-on.

garbear commented 10 months ago

Input looks great, thanks!

I like the new icon too. Is there any way you can make the dimensions 512x512?

KOPRajs commented 10 months ago

I was lucky enough to find the original GIMP source file, so I've exported it in 512x512 (the original is 540x540 so we can't get much more). I remember I was exporting it in this resolution to match the Genesis Plus GX icon.

Here is another version (without the shadow for now): icon

If you prefer this one I can create the shadow and replace it (the source image for this one is much better in terms of quality).

KOPRajs commented 10 months ago

Well, I couldn't resist. So here are both versions side by side, pick whichever you like more. icon icon

garbear commented 10 months ago

On a white background I like the shadow more muted, but we can't compare that against a dark background. From a content perspective the icon with the drive shows more gaming history than the icon without. So I think I'll have to go with option 1.

KOPRajs commented 10 months ago

I agree that from the content perspective the image with the drive shows more. On the other hand I was unable to find better image with both the drive and the 32X add-on and even the logo itself is more sharp on the other image. Also the Sega CD (with the drive) is preferred to be played in the Genesis Plus GX, only the Sega 32X is where users should go with the Picodrive, so maybe the second image feels better for me.

I've updated the image again (this time with the transparent background). If you agree, it is ready to be merged. If you still prefer the first image, I will swap them one more time, no problem.

You can compare the final versions here: https://github.com/kodi-game/game.libretro.picodrive/compare/79017bdf787cb9c741434f84573b2b408b6d2289..60b24ea422b1e08213cf981d31968f51d33e0d91

garbear commented 10 months ago

After reviewing your comparisons I completely agree with the current state of the PR. Will merge in 24 hrs if no objections