ScummVM will not start on Kodi 18 RC2

BeenThereScrewedUp commented 5 years ago

Bug report

Describe the bug

SCUMMVM will not start in libreelec v8.90.009 ALPHA and previous versions on an Odroid C2.

RetroArch Behavior

Here is a clear and concise description of what happens in RetroArch with the same core/game:

unknown

To Reproduce

Steps to reproduce the behavior:

Use image from libreelec.tv on Odroid C2
Install scummvm from kodi repo
Attempt to start scummvm. Get "An unknown error has occurred" message.

Debuglog

The debuglog can be found here:

11:53:39.650 T:4088546080 DEBUG: CPlayerCoreFactory::GetPlayers() 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: system rules 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: system rules 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: mms/udp 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: lastfm/shout 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtmp 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtsp 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvd 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvdimage 11:53:39.651 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: sdp/asf 11:53:39.652 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: nsv 11:53:39.652 T:4088546080 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: radio 11:53:39.652 T:4088546080 DEBUG: CPlayerCoreFactory::GetPlayers: matched 0 rules with players 11:53:39.652 T:4088546080 DEBUG: CPlayerCoreFactory::GetPlayers: adding retroplayer 11:53:39.652 T:4088546080 DEBUG: CPlayerCoreFactory::GetPlayers: added 1 players 11:53:39.652 T:4088546080 INFO: RetroPlayer[PROCESS]: Created process info for Amlogic 11:53:39.652 T:4088546080 DEBUG: RetroPlayer[PLAYER]: --------------------------------------- 11:53:39.652 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Game tag loaded 11:53:39.652 T:4088546080 DEBUG: RetroPlayer[PLAYER]: URL: 11:53:39.652 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Title: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Platform: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Genres: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Developer: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Game Code: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Region: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Publisher: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Format: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Cartridge type: 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: Game client: game.libretro.scummvm 11:53:39.653 T:4088546080 DEBUG: RetroPlayer[PLAYER]: --------------------------------------- 11:53:39.658 T:4088546080 DEBUG: ADDON: Dll Initializing - ScummVM 11:53:39.658 T:4088546080 DEBUG: SECTION:LoadDLL(/storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0) 11:53:39.659 T:4088546080 DEBUG: Loading: /storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0 11:53:39.667 T:4088546080 ERROR: AddOnLog: ScummVM: Unable to load: /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so: undefined symbol: _ZN3GUI13OptionsDialog5cleanEv 11:53:39.668 T:4088546080 ERROR: AddOnLog: ScummVM: Failed to load /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so 11:53:39.668 T:4088546080 ERROR: ADDON: Dll ScummVM - Client returned bad status (5) from Create and is not usable 11:53:39.669 T:4088546080 DEBUG: ------ Window Init (DialogConfirm.xml) ------ 11:53:41.085 T:4011844464 DEBUG: LIRC: - NEW 1c 0 KEY_ENTER devinput (KEY_ENTER) 11:53:41.114 T:4088546080 DEBUG: HandleKey: 11 (0x0b, obc244) pressed, action is Select 11:53:41.357 T:4088546080 DEBUG: ------ Window Deinit (DialogConfirm.xml) ------ 11:53:41.358 T:4088546080 ERROR: RetroPlayer[PLAYER]: Failed to initialize game.libretro.scummvm 11:53:41.359 T:4088546080 DEBUG: SECTION:UnloadDll(/storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0) 11:53:41.360 T:4088546080 INFO: ADDON: Dll Destroyed - ScummVM

Screenshots

Here are some links or screenshots to help explain the problem:

Your Environment

Used Operating system:

[ ] Android
[ ] iOS
[x] Linux
[ ] OSX
[ ] Raspberri-Pi
[ ] Windows
[ ] Windows UWP

Operating system version/name: Libreelec v8.90.009 ALPHA

Kodi version: Kodi 18 RC2

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

CvH commented 5 years ago

game.libretro.scummvm-2.0.0.1.110.zip could you try if this works (be aware that addon install may be broken at the moment at kodi)

you can also try to manually install it from the repo and choose the 2.0.0.1.110 version

BeenThereScrewedUp commented 5 years ago

Installed the file above from the zip archive. Same result as seen below.

16:38:20.125 T:4092764960 DEBUG: CAddonInstaller: installing from zip '/storage/downloads/game.libretro.scummvm-2.0.0.1.110.zip' 16:38:20.141 T:3651138416 DEBUG: Thread JobWorker start, auto delete: true 16:38:20.145 T:3651138416 DEBUG: CAddonMgr: game.libretro.scummvm unloaded 16:38:20.151 T:3651138416 DEBUG: Unpacking zip://%2fstorage%2fdownloads%2fgame.libretro.scummvm-2.0.0.1.110.zip/game.libretro.scummvm/ to /storage/.kodi/addons/temp/8b6b041c-3c80-4341-b6be-387f2ce8052e

16:38:31.965 T:4092764960 INFO: RetroPlayer[PROCESS]: Created process info for Amlogic 16:38:31.965 T:4092764960 DEBUG: RetroPlayer[PLAYER]: --------------------------------------- 16:38:31.965 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Game tag loaded 16:38:31.965 T:4092764960 DEBUG: RetroPlayer[PLAYER]: URL: 16:38:31.965 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Title: 16:38:31.965 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Platform: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Genres: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Developer: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Game Code: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Region: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Publisher: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Format: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Cartridge type: 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: Game client: game.libretro.scummvm 16:38:31.966 T:4092764960 DEBUG: RetroPlayer[PLAYER]: --------------------------------------- 16:38:31.973 T:4092764960 DEBUG: Creating resource directory: /storage/.kodi/userdata/addon_data/game.libretro.scummvm/resources 16:38:31.974 T:4092764960 DEBUG: ADDON: Dll Initializing - ScummVM 16:38:31.974 T:4092764960 DEBUG: SECTION:LoadDLL(/storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0) 16:38:31.974 T:4092764960 DEBUG: Loading: /storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0 16:38:31.985 T:4092764960 ERROR: AddOnLog: ScummVM: Unable to load: /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so: undefined symbol: _ZN3GUI13OptionsDialog5cleanEv 16:38:31.986 T:4092764960 ERROR: AddOnLog: ScummVM: Failed to load /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so 16:38:31.986 T:4092764960 ERROR: ADDON: Dll ScummVM - Client returned bad status (5) from Create and is not usable 16:38:31.987 T:4092764960 DEBUG: ------ Window Init (DialogConfirm.xml) ------ 16:38:31.987 T:4092764960 INFO: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY 16:38:33.243 T:4016038768 DEBUG: LIRC: - NEW 1c 0 KEY_ENTER devinput (KEY_ENTER) 16:38:33.293 T:4092764960 DEBUG: HandleKey: 11 (0x0b, obc244) pressed, action is Select 16:38:33.560 T:4092764960 DEBUG: ------ Window Deinit (DialogConfirm.xml) ------ 16:38:33.561 T:4092764960 ERROR: RetroPlayer[PLAYER]: Failed to initialize game.libretro.scummvm 16:38:33.561 T:4092764960 DEBUG: SECTION:UnloadDll(/storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0) 16:38:33.562 T:4092764960 INFO: ADDON: Dll Destroyed - ScummVM

CvH commented 5 years ago

Could you tell me how to reproduce? Just start scumm with some random game?

BeenThereScrewedUp commented 5 years ago

ScummVM will not even start to the initial UI to select a game. Crashes on start.

bastianbeischer commented 5 years ago

I have the same problem with the milhouse libreelec testbuild for kodi 18 on a RPI 3:

https://forum.kodi.tv/showthread.php?tid=298461

This is my debug log:

https://pastebin.com/FW4h7H3v

In particular:

13:32:31.637 T:1937841696 DEBUG: ADDON: Dll Initializing - ScummVM 13:32:31.637 T:1937841696 DEBUG: SECTION:LoadDLL(/storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0) 13:32:31.638 T:1937841696 DEBUG: Loading: /storage/.kodi/addons/game.libretro/game.libretro.so.1.1.0 13:32:31.665 T:1937841696 ERROR: AddOnLog: ScummVM: Unable to load: /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so: undefined symbol: _ZN3GUI13OptionsDialog5cleanEv 13:32:31.665 T:1937841696 ERROR: AddOnLog: ScummVM: Failed to load /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so

beta-tester commented 5 years ago

i have the same problem LibreELEC 9.0.1 / Kodi 18.1 on an RPi3B the log: https://paste.kodi.tv/efetivarij.kodi

https://forum.kodi.tv/showthread.php?tid=340424&pid=2828518#pid2828518

beta-tester commented 5 years ago

there is a ZIP file available that solves the problem to me. https://forum.libreelec.tv/thread/14371-retroplayer-scummvm/?postID=116866#post116866

svenfoo commented 4 years ago

Supposedly fixed with https://github.com/LibreELEC/LibreELEC.tv/pull/4129

However the fix hasn't been confirmed yet, and thus there's no back-port to Leia yet.

CvH commented 4 years ago

Supposedly fixed with LibreELEC/LibreELEC.tv#41291

not fixed :(

svenfoo commented 4 years ago

not fixed :(

Can you give some more detail? What version have you tested? Does it still fail to start with the same linker error?

CvH commented 4 years ago

Can you give some more detail? https://github.com/LibreELEC/LibreELEC.tv/pull/4129

or do I misread the comments ?

svenfoo commented 4 years ago

Can you give some more detail? LibreELEC/LibreELEC.tv#4129

or do I misread the comments ?

Well, the comments are difficult to interpret. But I'd conclude that the linker problem is fixed, but that there are more problems that need to be solved. This isn't really surprising, the add-on has been broken for quite a while. It's not uncommon that multiple issues pile up then.

beta-tester commented 4 years ago

ScummVM is still an issue on LibreELEC 9.2.1

beta-tester commented 4 years ago

still an issue on LibreELEC 9.2.2 for RPi2/3 with its most recent ScummVM plug-in update 2.1.1.8.1. i dont' understand, what is going on there...

CvH commented 4 years ago

we have also no idea whats wrong it build correctly but likely pulls something from the host system in and create a broken binary

currently no solution available besides self building and try if it works, also have to say this is nothing someone works atm

beta-tester commented 4 years ago

yes, the self builded result is works well, that's why i don't understand that the official compiled result file isn't working. i disabled the auto update function in LibreELEC for this plug-in to not get again a broken update next time.

BTW: is it normal, that every time i update the plug-in, all added games are gone from the list in scummvm user interface and all saved states as well.

CvH commented 4 years ago

BTW: is it normal, that every time i update the plug-in, all added games are gone from the list in scummvm user interface and all saved states as well.

no, user stuff is saved somewhere else LE:/storage/.kodi/userdata/addon_name/... if this is not working then it should be due a problem at the addon itself

beta-tester commented 4 years ago

user stuff is saved somewhere else LE:/storage/.kodi/userdata/addon_name/...

i will see if i can see added or saved games states there, when i add some. thank you.

CvH commented 4 years ago

sry wrong path /storage/.kodi/userdata/addon_data/game.libretro....../

beta-tester commented 4 years ago

/storage/.kodi/userdata/addon_data/game.libretro....../

i think i found the reason, why my games are gone all the time the add-on got an update... the added games are not stored in the folder you told me. the added games are stored in the file: /storage/.kodi/addons/game.libretro.scummvm/resources/system/scummvm.ini and this file gets overwritten by a blank/new version each time an update is arriving.

[scummvm]
lastselectedgame=simon1-cd-win-de
gui_browser_show_hidden=false
browser_lastpath=/media/scummvm/Day of the Tentacle
mute=false
versioninfo=2.1.1

[monkey-vga-de]
platform=pc
gameid=monkey
description=Monkey Island 1: The Secret of Monkey Island
language=de
extra=VGA
path=/media/scummvm/Monkey Island 1
guioptions=sndNoSpeech lang_German

[monkey2-de]
platform=pc
gameid=monkey2
description=Monkey Island 2: LeChuck's Revenge
language=de
path=/media/scummvm/Monkey Island 2
guioptions=sndNoSpeech lang_German

[comi-de]
platform=windows
gameid=comi
description=Monkey Island 3: The Curse of Monkey Island
language=de
object_labels=true
path=/media/scummvm/Monkey Island 3
guioptions=sndNoMIDI noAspect lang_German

[simon1-cd-win-de]
platform=windows
gameid=simon1
description=Simon the Sorcerer 1
language=de
extra=CD
path=/media/scummvm/Simon the Sorcerer 1
guioptions=sndNoSubs launchNoLoad lang_German

[simon2-cd-win-de]
platform=windows
gameid=simon2
description=Simon the Sorcerer 2
language=de
extra=CD
path=/media/scummvm/Simon the Sorcerer 2
guioptions=launchNoLoad lang_German

[dw-cd-de]
platform=pc
gameid=tinsel
description=Discworld 1
language=de
extra=CD
path=/media/scummvm/Discworld 1
guioptions=lang_German

[dw2-de]
platform=pc
gameid=tinsel
description=Discworld 2: Missing Presumed ...!?
language=de
extra=CD
path=/media/scummvm/Discworld 2
guioptions=noAspect lang_German

[tentacle-de]
gameid=tentacle
description=Day of the Tentacle
language=de
extra=CD
path=/media/scummvm/Day of the Tentacle
guioptions=lang_German

CvH commented 4 years ago

nice find, likely related to https://github.com/kodi-game/game.libretro.scummvm/issues/21 but maybe it is a problem of libretro.scummvm itself, otherwise other game addons might had the same problem

quick grep through the source didn't found anything to change this behaviour

beta-tester commented 4 years ago

i just tried out LibreELEC 9.2.2 for generic x86_64 PC... there the official ScummVM 2.1.1.8 add-on shows also the same start up issue - it is not starting at all. and i thought is was only an issue in the ARM build part...

################################################################################
# ... output of cat /storage/.kodi/temp/kodi.log
# LibreELEC release: Generic.x86_64-9.2.2
# 
################################################################################
2020-05-27 08:25:16.618 T:140656267495552  NOTICE: -----------------------------------------------------------------------
2020-05-27 08:25:16.618 T:140656267495552  NOTICE: Starting Kodi (18.6 Git:18.6-Leia). Platform: Linux x86 64-bit
2020-05-27 08:25:16.618 T:140656267495552  NOTICE: Using Release Kodi x64 build
2020-05-27 08:25:16.618 T:140656267495552  NOTICE: Kodi compiled 2020-03-22 by GCC 8.3.0 for Linux x86 64-bit version 5.1.16 (327952)
2020-05-27 08:25:16.618 T:140656267495552  NOTICE: Running on LibreELEC (official): 9.2.2, kernel: Linux x86 64-bit version 5.1.16
...
2020-05-27 08:25:19.120 T:140656267495552  NOTICE: ADDON: game.libretro v1.1.1.1 installed
2020-05-27 08:25:19.120 T:140656267495552  NOTICE: ADDON: game.libretro.scummvm v2.1.1.8.1 installed
...
2020-05-27 08:26:20.426 T:140656267495552   ERROR: AddOnLog: ScummVM: Unable to load: /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so: undefined symbol: _ZN3GUI13OptionsDialog16setupGraphicsTabEv
2020-05-27 08:26:20.426 T:140656267495552   ERROR: AddOnLog: ScummVM: Failed to load /storage/.kodi/addons/game.libretro.scummvm/game.libretro.scummvm.so
2020-05-27 08:26:20.426 T:140656267495552   ERROR: ADDON: Dll ScummVM - Client returned bad status (5) from Create and is not usable
2020-05-27 08:26:26.451 T:140656267495552   ERROR: RetroPlayer[PLAYER]: Failed to initialize game.libretro.scummvm

kodi-game / game.libretro.scummvm