Closed garbear closed 1 month ago
The DeSmuME buttonmap added in https://github.com/kodi-game/game.libretro.desmume/pull/4 contains the RETRO_DEVICE_POINTER feature, however apparently relative pointers are unimplemented: https://github.com/kodi-game/game.libretro/blob/2cb1ed77d3a31d73301447c60f600eaebccd2f07/src/libretro/LibretroTranslator.cpp#L617
RETRO_DEVICE_POINTER
case RETRO_DEVICE_POINTER: { break; // TODO }
This was breaking the input for NDS cores, as the game.controller.nds layout wouldn't match to any libretro features.
Before: Error about RETRO_DEVICE_POINTER not defined for mapto XML attribute, no input, empty controller in the in-game "Controls" button mapper.
mapto
After: Buttons appear in the in-game controller mapper, input works.
Description
The DeSmuME buttonmap added in https://github.com/kodi-game/game.libretro.desmume/pull/4 contains the
RETRO_DEVICE_POINTERfeature, however apparently relative pointers are unimplemented: https://github.com/kodi-game/game.libretro/blob/2cb1ed77d3a31d73301447c60f600eaebccd2f07/src/libretro/LibretroTranslator.cpp#L617This was breaking the input for NDS cores, as the game.controller.nds layout wouldn't match to any libretro features.
How has this been tested?
Before: Error about
RETRO_DEVICE_POINTERnot defined formaptoXML attribute, no input, empty controller in the in-game "Controls" button mapper.After: Buttons appear in the in-game controller mapper, input works.