LoadStandalone must call retro_load_game with NULL

kodi-game / game.libretro

Libretro compatibility layer for the Kodi Game API

GNU General Public License v2.0

37 stars 26 forks source link

Closed fetzerch closed 7 years ago

fetzerch commented 7 years ago

The [libretro API](Ref: https://github.com/libretro/RetroArch/blob/master/libretro-common/include/libretro.h#L605) documentation states that retro_load_game must be called with NULL as arguments for standalone games.

This fixes a crash in the scummvm core which supports both direct game launching and standalone mode. The crash was introduced by the change: https://github.com/libretro/scummvm/commit/4c1c4ff354e782734e34a0e7e556d8640046a8de.

garbear commented 7 years ago

The input hack is OK for now, but we really should fix that. I wonder why input for 2048 worked?

fetzerch commented 7 years ago

2048 doesn't work for me either without this patch.

garbear commented 7 years ago

weird. ok to merge?

fetzerch commented 7 years ago

Fine by me, yes. I've tried both 2048 and scummvm on Linux.