search

kodi-game / game.libretro

Libretro compatibility layer for the Kodi Game API
GNU General Public License v2.0
37 stars 26 forks source link

Rcheevos #84

Closed NikosSiak closed 2 years ago

NikosSiak commented 2 years ago

This PR adds support for rcheevos to RetroPlayer. This PR is used by https://github.com/xbmc/xbmc/pull/20913 and depends on it to be build

garbear commented 2 years ago

I scrutinized the code and found a couple suggestions.

garbear commented 2 years ago

I tried compiling on Windows and found the following warnings:

[ 11%] Building CXX object CMakeFiles/game.libretro.dir/src/cheevos/Cheevos.cpp.obj
Cheevos.cpp(242): warning C4267: '-=': conversion from 'size_t' to 'unsigned int', possible loss of data
Cheevos.cpp(245): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data
Cheevos.cpp(248): warning C4267: '-=': conversion from 'size_t' to 'unsigned int', possible loss of data
Cheevos.cpp(250): warning C4267: '+=': conversion from 'size_t' to 'unsigned int', possible loss of data

[ 25%] Building CXX object CMakeFiles/game.libretro.dir/src/libretro/MemoryMap.cpp.obj
MemoryMap.cpp(14): warning C4018: '<': signed/unsigned mismatch
garbear commented 2 years ago

Just pointing out, the last two commits should be squashed so that the build succeeds on every commit to aid in bisecting. But no need to update for this PR.