search

kodi-pvr / pvr.dvbviewer

Kodi's DVBViewer client addon
GNU General Public License v2.0
11 stars 26 forks source link

read user and pass settings as string and not integer #96

Closed phunkyfish closed 4 years ago

phunkyfish commented 4 years ago

6.0.2:

CiNcH83 commented 4 years ago

Just installed 6.0.1. Kodi at least does not crash anymore. But it can't connect to the DVBViewer Media Server due to this issue I suppose...

phunkyfish commented 4 years ago

There is a PR open for 6.0.2.

Testbuilds here: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.dvbviewer/detail/PR-96/1/artifacts

CiNcH83 commented 4 years ago

PVR still isn't starting up. Attaching a debug log...

LOG

CiNcH83 commented 4 years ago

Oh. Nice that the password is logged... Can you remove that from the respective log statement?

phunkyfish commented 4 years ago

Let’s get it to start up first

phunkyfish commented 4 years ago

@AlwinEsch do you have a dvbviewer backend for test this on?

AlwinEsch commented 4 years ago

No, that was the one where I asked for the test version of backend and where not allowed to get without pay.

phunkyfish commented 4 years ago

Ok, no worries. @manuelm then I’m afraid we are stuck here unless you can help?

Sorry we couldn’t fix it without bothering you.

CiNcH83 commented 4 years ago

No, that was the one where I asked for the test version of backend and where not allowed to get without pay.

Sent you a mail concerning this topic.

manuelm commented 4 years ago

@AlwinEsch I'm currently facing the issue that the PVR Manager isn't starting up although the PVR is running fine (the background thread is running and API calls do work).

Please let me elaborate: At start up the PVR marks itself to PVR_CONNECTION_STATE_CONNECTING and API calls like GetBackendName fail with PVR_ERROR_SERVER_ERROR. Upon successful connection to the backend the PVR moves to PVR_CONNECTION_STATE_CONNECTED and the API calls will succeed.

However I think due to the first failing API calls the PVRClient instance gets marked as bReadyToUse=false and this variable never transitions to true.

In the debug log I'm seeing exactly this: The first API calls are coming from CPVRClient::GetAddonProperties which calls GetBackendName. As this fails bReadyToUse gets set to false. As soon as the PVR transitions to PVR_CONNECTION_STATE_CONNECTED CPVRClients::ConnectionStateChange calls GetAddonProperties again. However bReadyToUse remains false causing the PVR Manager to always ignore the addon instance.

manuelm commented 4 years ago

@AlwinEsch I worked around the described PVR manager behavior with https://github.com/kodi-pvr/pvr.dvbviewer/commit/0d133c11d441b7188ab6b5c7dd386aba31e522ae. I still think it's a bug.

AlwinEsch commented 4 years ago

Thanks a lot for report and the fixes on addon. Would look the next time to imporve it on Kodi for this cases.