search

kodi-pvr / pvr.filmon

Kodi's Filmon client addon
GNU General Public License v2.0
4 stars 32 forks source link

[Testing Required] update to PVR addon API 5.7.0 #76

Closed fuzzard closed 6 years ago

fuzzard commented 6 years ago

This brings the addon upto API 5.7.0 compatibility Removed deprecated methods and stubbed out new ones Bumped jsoncpp to 0.10.6

Please note, ive not been able to test functionality at all. If anyone can let me know if the changes work, or need further tweaking. This was a quick attempt to get up and running, so feedback is very appreciated.

MilhouseVH commented 6 years ago

Thanks, this is now building fine with LibreELEC.

The add-on now requires a subscription, so I can't really run-time test it but I'll include it in future builds in case anyone else is able to test it.

fuzzard commented 6 years ago

Thanks for looking Ksooo Fixed what you've requested. Do let me know if there is anything else you want changed.

ksooo commented 6 years ago

Looking good now. Thanks. Much appreciated.

fuzzard commented 6 years ago

Had a second look at the implementation of GetChannelStreamProperties(), and i think i had it wrong. Ive pushed another commit to fixup the logic that i believe should work properly.

fuzzard commented 6 years ago

You were to quick for me. Should i just do another PR to fixup GetChannelStreamProperties()?

ksooo commented 6 years ago

No problem. Just do another PR.