kodi-pvr / pvr.hts

Kodi's Tvheadend HTSP client addon
GNU General Public License v2.0
136 stars 93 forks source link

Refactoring roadmap #27

Open Jalle19 opened 9 years ago

Jalle19 commented 9 years ago

I'm opening this here instead of creating a PR so we can come to an agreement on what should be done and what not. There are a couple of issues I'd like to address:

@ksooo do you agree with these points? If we decide to do this we should probably do it incrementally, starting from the top (separating classes into separate files) to keep the changes managable and reviewable.

ksooo commented 9 years ago

Full ACK to all points. :+1:, esp. for the incremental approach.

Not sure about the "separate subdirectory" for types in namespace tvheadend. What else will we have beside "tvheadend"?

ksooo commented 9 years ago

BTW, for the series recording stuff I already started not to squash everything into Tvheadend.[cpp|h]. ;-) => https://github.com/ksooo/pvr.hts/commits/series-recording-support

ksooo commented 9 years ago

One more todo: Get rid of CStdString, replace with std::string

ksooo commented 9 years ago

One more: Replace c casts with c++ casts

Jalle19 commented 9 years ago

Not sure about the "separate subdirectory" for types in namespace tvheadend. What else will we have beside "tvheadend"?

This is just a habit of mine, I like having the directory structure reflect the code structure as well (having a folder per namespace is similar to having a file per class).

Jalle19 commented 9 years ago

Just a heads up, I've started working on some of the stuff here

Jalle19 commented 8 years ago

I've almost finished factoring out some non-connection related stuff from CHTSPConnection, I'll put up a new PR to replace the two existing ones.