kodi-pvr / pvr.iptvsimple

IPTV Simple client for Kodi PVR
GNU General Public License v2.0
773 stars 372 forks source link

Feature Request: Force use of Local Channel Logos #505

Closed berkhornet closed 3 years ago

berkhornet commented 3 years ago

Hi. Would it be possible to include an option to force the use of locally stored channel logos, ignoring any logos in both the M3U and XMLTV files. Many thanks.

phunkyfish commented 3 years ago

That should already be the case if local path is used for logos.

You may need to clear the thumbnail cache

phunkyfish commented 3 years ago

You need to do something like this to clear the cache: https://github.com/kodi-pvr/pvr.vuplus/issues/252

berkhornet commented 3 years ago

Many thanks for you reply. I've tried you suggestion but still have an issue. I'm using XEEV Editor to maintain my m3u files. This has an option to remove picons (logos) from the generated m3u files. However, when XEEV syncs with the provider the providers logos reappear in the generated m3u file, and are displayed in the PVR EPG instead of my local logos.

I also use the XEEV m3u files on apps other than Kodi and need the providers logos there.

I hope that explains my situation more clearly. Many thanks for your time.

On another point, I've tried the new functionality in v 7.6.0 regarding XEEV format catch up. This works a great - many thanks. I did notice that I needed to set the "Use XC2 API Protocol" flag in the XEEV editor which you may want to add to the read me file. Thanks again.

phunkyfish commented 3 years ago

Sorry, I misunderstood your question. If there is a logo in the M3U that will be used first so that makes sense, M3U trumps local path. I don't really know anything about the XEEV editor, it was just a request I implemented.

Why not just have 2 playlists in XEEV one for Kodi without the icons and another for everything with them? The local channel logo path in kodi is supposed to be a fallback for when none are given in the M3U file.

berkhornet commented 3 years ago

Thanks again for your reply. Unfortunately having two playlists isn’t the answer, because every time the playlist without icons syncs with the iptv provider, the icons are updated into the playlist. it is then necessary to manually go into the editor and clear the icons.

Regards Mick


From: phunkyfish @.> Sent: Friday, April 9, 2021 11:05:57 AM To: kodi-pvr/pvr.iptvsimple @.> Cc: berkhornet @.>; Author @.> Subject: Re: [kodi-pvr/pvr.iptvsimple] Feature Request: Force use of Local Channel Logos (#505)

Sorry, I misunderstood your question. If there is a logo in the M3U that will be used first so that makes sense, M3U trumps local path. I don't really know anything about the XEEV editor, it was just a request I implemented.

Why not just have 2 playlists in XEEV one for Kodi without the icons and another for everything with them? The local channel logo path in kodi is supposed to be a fallback for when non are given in the M3U file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkodi-pvr%2Fpvr.iptvsimple%2Fissues%2F505%23issuecomment-816574780&data=04%7C01%7C%7C877df25b2bba4913209008d8fb3f1202%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637535595594704270%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eq0LzlLa%2FkKewsxhG9T%2BIdSA6kG6wtIuGvoMO0G805U%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQFFLX3REMRMZEU6THOPAX3TH3GQLANCNFSM42UPUR7Q&data=04%7C01%7C%7C877df25b2bba4913209008d8fb3f1202%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637535595594704270%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MjFApeN6v9YJc99oSclgZ%2BOwv7o3EQqJ%2FlIdb8C6rxk%3D&reserved=0.

phunkyfish commented 3 years ago

Ah, ok. Sounds like more of a bug XEEV but let me look and see what is possible.

phunkyfish commented 3 years ago

PR: https://github.com/kodi-pvr/pvr.iptvsimple/pull/506 Testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.iptvsimple/detail/PR-506/1/artifacts

Under channel logos in the addon settings there is a new advanced setting (it will only show if you have a local path selected). Please test it.

berkhornet commented 3 years ago

Hi. That test build works very well. I downloaded an m3u file that included channels logos, but my locally stored logos were displayed. Thank you.

Is it possible to extend that setting to remote m3u files?

UPDATE: I've noticed that the new setting "for local path ignore logos from m3u" persists even if a remote path is set. So I tested using a remote file that included logos and found that my locally stored logos were displayed.

Thanks again for your help.

phunkyfish commented 3 years ago

The path is the logos path not the M3U path which is probably why it still works.

berkhornet commented 3 years ago

Ok, I understand, Many thanks for your help with this.

From: phunkyfish @.> Sent: 09 April 2021 14:51 To: kodi-pvr/pvr.iptvsimple @.> Cc: berkhornet @.>; Author @.> Subject: Re: [kodi-pvr/pvr.iptvsimple] Feature Request: Force use of Local Channel Logos (#505)

The path is the logos path not the M3U path which is probably why it still works.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkodi-pvr%2Fpvr.iptvsimple%2Fissues%2F505%23issuecomment-816696727&data=04%7C01%7C%7C96cbadeb49e44545432d08d8fb5e794d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637535730461436617%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=HjOqJR3B8D6fmNdiy7BEyfQ6djQenfd5KtAlbKTHmCo%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQFFLXYADRT2UGOTTWIVUB3TH4A3JANCNFSM42UPUR7Q&data=04%7C01%7C%7C96cbadeb49e44545432d08d8fb5e794d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637535730461436617%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DNovQubnKNlvOag4acuKpvRowgb9saszMloVd3JOzYg%3D&reserved=0.

phunkyfish commented 3 years ago

Released 7.6.1, closing issue.