Closed thexai closed 6 months ago
I have reproduced locally and build fine with this PR, not sure if current failure in azure pipelines is related or not...
CD "V:\kodi\tools\buildsteps\windows\x64-uwp"
make-addons.bat inputstream.ffmpegdirect pvr.iptvsimple
Maybe better fix is update xz-utils to 5.4.3 same as inputstream.ffmpegdirect
ping @phunkyfish and @AlwinEsch
Probably better to keep them the same. Why not update both addons to the same latest version?
Also, don’t forget that you need to update the sha256 hash too.
Why not update both addons to the same latest version?
Tested locally and "not works" or is not too simple. Needs more changes in CMakeLists, etc. this is out of my area...
If it helps this was working fine until some weeks ago (2024-02-04). then the breakage is due some recent change in this repo, others binary addons repos or the build system updates/changes.
Tested this PR locally build ALL UWP-64 / Xbox binary add-ons:
Fix consists in isolate xz-utils 5.2.4 version then is forced to build specifically for this addon and can coexists with 5.4.3 version in
..\kodi\cmake\addons\build
(the other version not has version in folder name)
All addons seems are build successfully for UWP-64 using kodi\tools\buildsteps\windows\x64-uwp\make-addons.bat
script:
Ok, I’ll take a look later this week.
Ok, as it turns out ffmpedirect uses a much newer version and means we can delete all that cmake code and use a single depends config for all platforms, so a nice bit of tech debt removed. I also updated the other deps to match ffmpegdirect.
Correction, in the end I couldn't remove the extra CMake config for xz-utils, but the versions now match ffmpegfdirect. So closing this PR.
UWP fails to build (when build all add-ons at time) due xz-utils "version conflict".
This add-on is use older version than others and cmake not detects properly.
Without this (or other solution)
pvr.iptvsimple
will not be included on Xbox v21 RC1 installer:https://jenkins.kodi.tv/view/Windows/job/WIN-UWP-64/24993/
Latest installer that includes binary add-on in is: Kodi-20240204-99d8703b-master-x64.msix