Open mrmojo666 opened 5 years ago
I've forked this repo , and I'm going to try to modify this :
snprintf(command, 256, "TimeshiftChannel:%i|%s|False\n", channelinfo.iUniqueId, sResolveRTSPHostname);
in to this: snprintf(command, 256, "TimeshiftChannel:%i|%s|True\n", channelinfo.iUniqueId, sResolveRTSPHostname);
if I've understood, looking at the mediaportal server plugin code. If i pset that parameter to True it should trigger a timeshift stop on the server before tuning the new channel.
I'll let you know the result of this test
unfortunately is not that simple...
I post also here the same message taht i posted on the forum: https://forum.kodi.tv/showthread.php?tid=342732&pid=2882328#pid2882328
I still trying to understand this issue. I've tried also a different pvr server (Nextpvr) a different kodi addon Nextpvr client. At the start i had the same audio switch issue on channel change, but juggling with their addon i found they have a setting that stop the stream during a channel change. And it made the magic: no more audio issues when channge change. At this point I started to be confused, in mediaportal client setting there is a fastchannel switch that if i'm not wrong should do the same, so if the fast change switch is not selected I'm expecting that th stream is closed on each channel change. So i started to look at your code on github and i found that in the very early implemetation of your plugin there is a function that is named switchchannel that check that setting and in case call CloseLiveStream before the OpenLiveStream.
https://github.com/margro/xbmc-pvr-addons/blob/development/addons/pvr.mediaportal.tvserver/src/pvrclient-mediaportal.cpp
in the new implementations i can't find a SwitchChannel function but (if I've correctly understood) it is always called a OpenLiveStream function for start tv or to change channel.
inside this fuction i can't find any check on fastchannel switch setting , so the CloseStream is called only in case of errors.
https://github.com/kodi-pvr/pvr.mediaportal.tvserver/blob/63de57a99ba5deabe2a710124224fd593bccdba4/src/pvrclient-mediaportal.cpp
Can you confirm that I'm not wrong and the fastchannel setting is ignored ?
Thank you