kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

Variable initialization error #105

Closed emveepee closed 4 years ago

emveepee commented 4 years ago

Variable m_complete not initialized to false, extended timeshift may not issue leases

emveepee commented 4 years ago

I tested this fix on aarch64 and live tv in extended mode worked, where an earlier test in 3.3.17 failed. With initialization in other test platforms I could not duplicate the problem but m_complete not defaulting to false is a logical explanation of why leases were not being sent for this condition

https://github.com/kodi-pvr/pvr.nextpvr/blob/Matrix/src/buffers/Buffer.cpp#L87

I committed this for Leia production users first and will update Matrix after this is accepted