search

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

6.1.0 Enhancement #138

Closed emveepee closed 4 years ago

emveepee commented 4 years ago

Add optional season on recordings, pass through genres. Don't lock out addon on network error.

emveepee commented 4 years ago

It is not clear why all the Windows failed with tinyxml even when the Jenkins and Travis builds are fine. Also it seems the Travis information which Ia cleaned up a bit for this build doesn't seem to be on the build but I found it here. https://travis-ci.org/github/kodi-pvr/pvr.nextpvr/builds/713485382 I expect come more will be fixed up with PR 141 and the change to hiddenn

I am hoping that this can be released soon. Some users are already testing the earlier artifacts and I'd like to start moving to tinyxml-2 now before adding some new backend calls for v5. @sub3 @phunkyfish could you please review.

phunkyfish commented 4 years ago

There is something up with the azure pipelines currently. Not sure what is. Tagging @AlwinEsch for reference.

emveepee commented 4 years ago

@AlwinEsch I did another PR today with the same azure pipeline issues.

AlwinEsch commented 4 years ago

Have created a issue here https://developercommunity.visualstudio.com/content/problem/1132859/failure-about-cstrawberrycbinpatchexe-since-202007.html, hopefully they fix it soon.

emveepee commented 4 years ago

@sub3 @phunkyfish any chance for a review? I'd really like to see this merged and tagged and then I can fix up the tinyxml-2 PR and move forward.

AlwinEsch commented 4 years ago

About the Azure problem I found the reason, see https://github.com/xbmc/xbmc/pull/18247 They have there now cmake 3.18.0 and this breaks the current Kodi.

AlwinEsch commented 4 years ago

One part, seen there the commit names "Connection state change #1" and "Connection state change #2" them link against requests.

With # makes wrongly links to them and send also maybe mails to places where not need.

emveepee commented 4 years ago

About the Azure problem I found the reason, see xbmc/xbmc#18247 They have there now cmake 3.18.0 and this breaks the current Kodi.

I upgraded to 3.18.1 and do see the same issue so I reverted to 3.17.3 which is clean. The change probably requires I rebuild the base from scratch so I will wait for this PR to merge to make sure it is clean.

Confirmed fixed now with cmake 3.18.1 as a new install

emveepee commented 4 years ago

On part, seen there the commit names "Connection state change #1" and "Connection state change #2" them link against requests.

With # makes wrongly links to them and send also maybe also mails to places where not need.

Ok removed the # I didn't know this. I have two more coming after the tinyxml-2 merge too

phunkyfish commented 4 years ago

I can’t review till next week as I’m away.

emveepee commented 4 years ago

I can’t review till next week as I’m away.

Thanks I will ask @sub3 to review and release this thanks users are using the artifacts anyway.

If you have time could you address the comment on using std::stoi in general, it looks like the change that was noted was automated since I don't see the values in c to c++ just to use stoi but I will never use it if it is wrong.