search

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

Use updated c++17 platform #148

Closed emveepee closed 4 years ago

emveepee commented 4 years ago

Test of changed platform to avoid hacking pvr.nextpvr for c++17 changes

emveepee commented 4 years ago

@phunkyfish this is how I believe it should be down pointing to platform with the change https://github.com/emveepee/platform/commit/4016b39b3ab1709f60befc1e9b73725f9471e62d

phunkyfish commented 4 years ago

I agree but changing platform is not so simple. As git is used in shallow mode to pull the revision that will disappear if we add a commit.

As it is called so many times github will throttle and it will be the source of many issues. Remember it is shared across kodi 18 and 19.

phunkyfish commented 4 years ago

I did the last time and broke lots of stuff. It’s how I found out not to do that!

emveepee commented 4 years ago

I did the last time and broke lots of stuff. It’s how I found out not to do that!

If a submit a PR to new branch not to default/master isn't the only access via the hash? I would just need a new branch to submit to. I checked and there are other branches on it so branches are possible without conflict.

emveepee commented 4 years ago

This is closed as alternate solutions are being worked on