search

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

Sync translations #230

Closed gade01 closed 1 year ago

gade01 commented 1 year ago

This PR will sync translations and translation metadata between matrix and nexus branches.

emveepee commented 1 year ago

@gade01 Can you do a global change on these In browsing the file I notice that #30504 needs to be changed in the source

from

msgctxt "#30504" msgid "Not enabled for Matrix when remote"

to

msgid "Not enabled when remote"

I would like to take out "for Matrix " in all of them.

lrusak commented 1 year ago

@emveepee i think it works that you update the en_gb language and all others are synced from that.

emveepee commented 1 year ago

@emveepee i think it works that you update the en_gb language and all others are synced from that.

I think so too but doesn't the translation automation happen after the merge? I'd like to do this before the merge and tag that we hope to do tomorrow.

If it can't be removed, can Matrix be changed to Nexus and then I will merge in the removal later. Serves me right for having a version specific name in there.

gade01 commented 1 year ago

@emveepee So you'd like to change a string in en_gb as well? Shouldn't that be done in a seperate PR?

Weblate will always sync all languages based on the source file.

emveepee commented 1 year ago

@emveepee So you'd like to change a string in en_gb as well? Shouldn't that be done in a seperate PR?

I was planning on including it with PR223, but if I need to do another PR to get it done before tomorrow I will. Does it happen with the merge or tag?

gade01 commented 1 year ago

I can easily include the change in this PR.

Weblate will sync instantly when changes are merged into en_gb.

emveepee commented 1 year ago

OK thanks. I will ask @sub3 to merge in PR223 and PR230 tonight if he can and we will see what Weblate automation does and tomorrow and maybe can merge it with the tag too.

gade01 commented 1 year ago

@emveepee string id 30504 has been changed now in a seperate commit.

emveepee commented 1 year ago

@emveepee string id 30504 has been changed now in a seperate commit.

I already update PR 233 to do this, since I figured the addon was responsible for that file. It seems I missed Nexus final anyway so it won't make it to ATV

emveepee commented 1 year ago

@gade01 ok the merges seems ok now, so will there be another PR generated now or can we tag this?

gade01 commented 1 year ago

@emveepee You can tag it if you like. I'll move Weblate to Nexus branch now, which will probably create a new PR.