search

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

Control access to recordings and timers #260

Closed emveepee closed 4 months ago

emveepee commented 4 months ago

Provide options to access Live TV only (no recording or timer access) or to disable timers only.

Add new timer type single channel all episodes (filtered for new and duplicate at the backend) and Daily Timeslot recording.

emveepee commented 4 months ago

@phunkyfish could you please re-review. I revamped the original commit to one setting rather than two. I found a few hardcoded English string in instance-settings.xml that I was lax on updating. I also fixed an outstanding issue with missing timer types that had not been added to Kodi.

ksooo commented 4 months ago

Don’t want to block this PR. only out of curiosity: does nextpvr backend not have a multi user concept? Different users can log in with different credentials, having their own set of permissions/config? For me, this would be a clean way to implement what the user requested in the forum. Nothing that should be done by the addon, imo, if the backend offers multi user support.

emveepee commented 4 months ago

Don’t want to block this PR. only out of curiosity: does nextpvr backend not have a multi user concept? Different users can log in with different credentials, having their own set of permissions/config? For me, this would be a clean way to implement what the user requested in the forum. Nothing that should be done by the addon, imo, if the backend offers multi user support.

No the backend doesn't support multi-user. If I had access to the backend source this is probably the first thing that I would change. As an example having one resume point for a recording can cause conflicts, which is why I added an option to store the resume point locally. That all being said over the almost 20 years I have been involved with the project there have been very few calls to add multi-user support. I think users like the simplicity of installing NextPVR and most wouldn't be bothered to use the feature anyway.