Bug fixes in seeking and fix for uninitialized usec in struct timeval

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon

GNU General Public License v2.0

22 stars 33 forks source link

Bug fixes in seeking and fix for uninitialized usec in struct timeval #76

Closed mlburgett closed 5 years ago

ksooo commented 5 years ago

@sub3 the "Update addon.xml..." commit looks really insane. Look at all these strings.po changes. Only changes to en_gb must be committed, all other languages are handled through Transifex...

mlburgett commented 5 years ago

@ksooo I know it looks strange in the commit, I had some issues squashing my changes in my repo before putting up the PR, but if you look at the 'Files Changed' tab for this PR, it looks as I expected.

ksooo commented 5 years ago

I would not have approved/merged the PR in this state. ;-)

sub3 commented 5 years ago

Sorry Ksooo - we'll try to get our shit a little more together for the next PR :-)

mlburgett commented 5 years ago

I think it was because my changes were in progress over a number of months, and I pulled in the upstream master changes occasionally. So while those changes were in my commit in my repo, they were identical to changes already in this repo, and fell out in the PR. Next time I think I squash first, and then merge my working branch into my master, which was already synced with the upstream.