search

kodi-pvr / pvr.nextpvr

Kodi's NextPVR client addon
GNU General Public License v2.0
22 stars 33 forks source link

Delete recording trigger change, cleanup initialization code #90

Closed emveepee closed 5 years ago

emveepee commented 5 years ago

Removed unnecessary trigger after deleting a recording, prevent delete of in progress recording, clean up error message. Added playback of plugin:/ URLs. Cleaned up MAC address logic and skip WOL for localhost. Fixed default for settings.xml

emveepee commented 5 years ago

Note that with change if a user tries to delete a folder with an in-progress recording they will see this dialog. error

The log will show " Add-on 'NextPVR (xx.xx.xx.xx):connected' returned an error: recording already running"

No way to avoid this error message, we probably need to raise a Kodi issue not to delete folders with in-progress recordings.

emveepee commented 5 years ago

I resubmitted this to deal with an incorrect default in settings.xml. In compiling there was a failure

D:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\cmake\addons\build\p8-platform\src\p8-platform\src\windows\dlfcn-win32.cpp(276): fatal error C1090: PDB API call failed, error code '23': (0x000006BA)

NMAKE : fatal error U1077: 'C:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe' : return code '0x2'

Outside my control. Not sure what the next step is. Please advise