search

kodi-pvr / pvr.stalker

A PVR Client that connects Kodi to Stalker Middleware
GNU General Public License v2.0
41 stars 64 forks source link

[Nexus] update libxml2 on depends to 2.9.10 #167

Closed AlwinEsch closed 2 years ago

AlwinEsch commented 2 years ago

This should also fix faulty Windows UWP builds:

xml2.lib(encoding.c.obj) : error LNK2001: unresolved external symbol iconv_close
xml2.lib(encoding.c.obj) : error LNK2001: unresolved external symbol iconv
xml2.lib(encoding.c.obj) : error LNK2001: unresolved external symbol iconv_open
xml2.lib(xmlreader.c.obj) : error LNK2001: unresolved external symbol xmlValidatePopElement
pvr.stalker.dll : fatal error LNK1120: 4 unresolved externals

WARNING: This need be tested to confirm correct operations about add-on!

ksooo commented 2 years ago

AlwinEsch requested a review from ksooo

Sorry, cannot review as I have no clue about our build system and I cannot test as I have no suitable hardware.

phunkyfish commented 2 years ago

Windows appears to still be failing.

AlwinEsch commented 2 years ago

With the Version 2.9.10 becomed it now working. To use newest and his own cmake makes some Problems on Windows, thats why I used 2.9.10 now and taken CMakeLists.txt from inputstream.ffmpegdirect with few changes on compile flags.

ksooo commented 2 years ago

@AlwinEsch is a backport to Matrix feasible or is this problem Nexus-only?

ksooo commented 2 years ago

is a backport to Matrix feasible or is this problem Nexus-only?

Answering my own question. Yes, there already is a PR for thsis. ;-)