Update 21.1.0 Stalker crashed on Windows

[DWH-WFC]

Hello from Germany. Since the update last night, Kodi keeps crashing shortly after starting. It always freezes briefly when Stalker starts and then crashes. It worked fine with the last version. A new installation of Kodi and Stalker produces the same result. When upgrading from Kodi 20.5 to 21.0, it works until the next Kodi restart, then Kodi also crashes when loading the client.

kodi.log kodi_crashlog-21.0 Git_20240406-60c4500054-20240623-122122.dmp kodi_stacktrace-21.0 Git_20240406-60c4500054-20240623-122122.txt

[phunkyfish]

Could you create a full debug log capturing the crash please?

https://kodi.wiki/view/Log_file

[DWH-WFC]

I hope that is correct. I reinstalled Kodi and then installed the Stalker Client via the Kodi repo. Immediately after the installation, Kodi crashed again. kodi.log kodi_crashlog-21.0 Git_20240406-60c4500054-20240623-130841.dmp kodi_stacktrace-21.0 Git_20240406-60c4500054-20240623-130841.txt

[DWH-WFC]

Here are the 2 logs when I use a new installation and update from Stalker 21.0.1 to 21.1.0.

The Version 21.0.1 works fine.

kodi.log kodi.old.log

[phunkyfish]

Can you try two things?

First try to install 21.0.1 of the addon and see if the crash goes away.

Secondly, try deleting the addon_data/pvr.stalker (please back it up first) and see if the behaviour changes. You’ll need to reconfigure the addon when you do this. If it doesn’t work I might get you to sen some your backup to see if I can reproduce the crash.

[MARIOSW226]

Try installing the old version 21.0.0, disable automatic updates. That's what I did, and it works.

[phunkyfish]

Try installing the old version 21.0.0, disable automatic updates. That's what I did, and it works.

This will make the addon functional but will not help figure out that the issue is. Out of interest, are you also on Windows?

[Sachin736]

I installed new version on windows, it crashed and can't even add address and url.

[phunkyfish]

Is it only windows that has this problem? Has anyone uncovered issues on another platform?

[phunkyfish]

I installed new version on windows, it crashed and can't even add address and url.

Is this a fresh install or an update on a previous version?

[Sachin736]

Fresh install Kodi omega 21.0 and stalker client 21.1.0. When pvr client installed kodi crashed.

[ppoeps4]

stalker client 21.1.0 crash.On windows.

[Sachin736]

Yes. When you install it kodi closes automatically.

[phunkyfish]

Can someone try on a non windows platform? If it doesn’t crash there might help narrow it down.

[phunkyfish]

Some test settings.xml files might also help for testing.

[DWH-WFC]

So with 21.0.1 it works great. After an update to version 21.1.0, Kodi crashes immediately. The migration of the settings.xml is not even carried out. A notification appears in the top right that the Stalker Client has started and then causes Kodi to crash. In the test, all 5 providers were completely filled out and worked without problems. But regardless of whether it is an existing or new installation of Kodi, the behavior is the same. If I copy the contents of the 21.0.1.zip back into the "addons" folder after the crash, the client works again without problems.

21.0.1 to 21.1.0.log

[DWH-WFC]

The settings.xml remains unchanged. I can use it again immediately after copying version 21.0.1 back in.

In the log from line 706 I noticed that it is trying to read the settings.xml but it cannot find any content even though it is available.

[DWH-WFC]

Is it only windows that has this problem? Has anyone uncovered issues on another platform?

I have just tested version 21.1.0 again on Android TV. It works without any problems there

[MARIOSW226]

Try installing the old version 21.0.0, disable automatic updates. That's what I did, and it works.

This will make the addon functional but will not help figure out that the issue is. Out of interest, are you also on Windows?

Yes I am on Windows. But with my phone v21.1.0 works well. I think that it's only on Windows that it's crash.

[phunkyfish]

Try installing the old version 21.0.0, disable automatic updates. That's what I did, and it works.

This will make the addon functional but will not help figure out that the issue is. Out of interest, are you also on Windows?

Yes I am on Windows. But with my phone v21.1.0 works well. I think that it's only on Windows that it's crash.

Thanks for confirming

[phunkyfish]

So with 21.0.1 it works great. After an update to version 21.1.0, Kodi crashes immediately. The migration of the settings.xml is not even carried out. A notification appears in the top right that the Stalker Client has started and then causes Kodi to crash. In the test, all 5 providers were completely filled out and worked without problems. But regardless of whether it is an existing or new installation of Kodi, the behavior is the same. If I copy the contents of the 21.0.1.zip back into the "addons" folder after the crash, the client works again without problems.

21.0.1 to 21.1.0.log

So there is no instance-settings-1.xml created? That likely means the crash is happening as part of the settings migration. I can create a testbuild for you to try with some extra logging to try and figure out where the crash occurs.

[DWH-WFC]

Yes, exactly, no instance settings are created because the crash happens beforehand. Yes, I can test the test build if you send it to me.

[phunkyfish]

Yes, exactly, no instance settings are created because the crash happens beforehand. Yes, I can test the test build if you send it to me.

Please try these testbuilds on windows and post a full debug log. If the crash is happening during migration you should see debug log entries starting with ZZ

https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/1/artifacts

[Sachin736]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

[phunkyfish]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please?

Setting.Details.SettingList is JSONRPC related so safe to ignore. Plus it’s in both log files.

[Sachin736]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please?

Setting.Details.SettingList is JSONRPC related so safe to ignore. Plus it’s in both log files.

Check these two, it's in debug mode kodi.old.log kodi.log

[phunkyfish]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please? Setting.Details.SettingList is JSONRPC related so safe to ignore. Plus it’s in both log files.

Check these two, it's in debug mode kodi.old.log kodi.log

Your case appears to be different. If you look in userdata\addon_data\pvr.stalker I assume you have an instance_setttings-1.xml file? Which mean the settings migration has already run and so none of the new log statements will print. This could mean the crash is your case happens after settings load.

[Sachin736]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please? Setting.Details.SettingList is JSONRPC related so safe to ignore. Plus it’s in both log files.

Check these two, it's in debug mode kodi.old.log kodi.log

Your case appears to be different. If you look in userdata\addon_data\pvr.stalker I assume you have an instance_setttings-1.xml file? Which mean the settings migration has already run and so none of the new log statements will print. This could mean the crash is your case happens after settings load.

Yes crash happened when stalker client loads.

[nagysifa]

Having the same isues on my Windows 10 ( 64bit and 32 bit ) installations ... the same config ( copyed the complete "portable_data" folder to each Windows ) works as expected on both of my Windows 11 configurations.

[Sachin736]

Could not parse type "Setting.Details.SettingList" kodi.old.log kodi.log

That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please? Setting.Details.SettingList is JSONRPC related so safe to ignore. Plus it’s in both log files.

Check these two, it's in debug mode kodi.old.log kodi.log

Your case appears to be different. If you look in userdata\addon_data\pvr.stalker I assume you have an instance_setttings-1.xml file? Which mean the settings migration has already run and so none of the new log statements will print. This could mean the crash is your case happens after settings load.

Also, When the addon is installed it crashed. I can't provide url and mac address for it.

In userdata\addon_data\ folder pvr.stalker is not there. No inputs is given. Only addons folder has pvr.stalker

[Sachin736]

Having the same isues on my Windows 10 ( 64bit and 32 bit ) installations ... the same config ( copyed the complete "portable_data" folder to each Windows ) works as expected on both of my Windows 11 configurations.

Yes. In Windows 11 it works fine.

[DWH-WFC]

For me it crashes on my PC under Windows 11. I tested it on my laptop with Windows 11 and it works there. I'm going to try the test build now.

[DWH-WFC]

So I've now done 2 tests. Both with a new installation of Kodi without additional add-ons. 1st test Installation of PVR 21.1.1.zip without existing settings.xml

2nd test Installation of PVR 21.0.1.zip created settings.xml and entered access (works). Updated PVR 21.1.1.zip. Crashes immediately. (Access URL obscured with XXXXXXXX)

kodi_new_Install-PVR_Install_from_zip.log Update_from_21.0.1_to_21.1.1.log

[phunkyfish]

So I've now done 2 tests. Both with a new installation of Kodi without additional add-ons. 1st test Installation of PVR 21.1.1.zip without existing settings.xml

2nd test Installation of PVR 21.0.1.zip created settings.xml and entered access (works). Updated PVR 21.1.1.zip. Crashes immediately. (Access URL obscured with XXXXXXXX)

kodi_new_Install-PVR_Install_from_zip.log Update_from_21.0.1_to_21.1.1.log

Thanks for the testing so far. The crash appears to happen after settings are loaded, maybe when authenticating. The strange thing is that it appears to load default settings and not do a migration, not sure why. I've added more logging, could you test again?

New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/2/artifacts

[DWH-WFC]

Tested in the same way as before. See order above.

kodi_new_Install-PVR_Install_from_zip.log Update_from_21.0.1_to_21.1.1.log

[phunkyfish]

Tested in the same way as before. See order above.

kodi_new_Install-PVR_Install_from_zip.log Update_from_21.0.1_to_21.1.1.log

Brilliant, we are getting closer. Can you run the same test with these testbuilds?https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/3/artifacts

[Sachin736]

kodi.old.log kodi.log

[phunkyfish]

kodi.old.log kodi.log

Thanks again, closer still. More testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/4/artifacts

The builds should be there in a few minutes, just building now.

[Sachin736]

kodi.old.log kodi.log

[phunkyfish]

kodi.old.log kodi.log

Very strange. So it looks like the problem is with the mutex used for authentication, or the thread is blocked somewhere. I can try cleaning up that code a bit and/or fix what’s blocking it. Weird that it only causes a problem on windows.

[DWH-WFC]

Do you still need the final tests from me? Or have you found the error now?

[phunkyfish]

Good for now thanks. I need to figure out where’s it’s blocking and add more logging. Will let you know when I have another build to test.

[phunkyfish]

Do you still need the final tests from me? Or have you found the error now?

Ok, one more set of testbuilds I need a debug log for: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/5/artifacts

[DWH-WFC]

Thank you for your work. Just let us know if you want us to test something.

[DWH-WFC]

Do you still need the final tests from me? Or have you found the error now?

Ok, one more set of testbuilds I need a debug log for: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/5/artifacts

No Problem.

[DWH-WFC]

Here are the latest tests. The procedure is the same as the last ones I did.

kodi_new_Install-PVR_Install_from_zip.log Update_from_21.0.1_to_21.1.1.log

[phunkyfish]

Ok, first attempt at a fix. Testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/6/artifacts

Will need a full debug log as usual.

[Sachin736]

kodi.old.log kodi.log only pvr addon.log

[phunkyfish]

Ok, no change. I’m going to ask someone who develops on windows to try running it and see if they can find the cause of the crash.

[phunkyfish]

Can someone try this using the latest version of the add-on but instead a nightly version of kodi omega, on a non working windows device/PC?

https://mirrors.kodi.tv/nightlies/

[Sachin736]

Can someone try this using the latest version of the add-on but instead a nightly version of kodi omega, on a non working windows device/PC?

https://mirrors.kodi.tv/nightlies/

Works for KodiSetup-20240626-7508b879-Omega-x64 and pvr 21.1.0 kodi.log