search

kodi-pvr / pvr.vbox

Kodi VBox TV Gateway PVR addon
GNU General Public License v2.0
4 stars 22 forks source link

Implement GetStreamTimes API #224

Closed phunkyfish closed 4 years ago

phunkyfish commented 4 years ago

4.5.0

On recordings the Ui will correctly show the in progress recordings (red dot in Recordings view) and when viewing them the duration will increase as you watch.

phunkyfish commented 4 years ago

Sure, can drop reformatting. Can put it back after the review.

It was broken for Mac before kodi 18 release. Fixed in 19 I think but still a useful script if you jump between addons like I do.

phunkyfish commented 4 years ago

Ok, should be ready for review now.

Jalle19 commented 4 years ago

Looks good in general, I take it the RecordingReader class is copied from some other addon?

phunkyfish commented 4 years ago

Ya, comes from vuplus, prior to that dvbviewer 😉

Jalle19 commented 4 years ago

Ya, comes from vuplus, prior to that dvbviewer wink

I suspect there's a lot of code that could be factored out to a "libkodipvr" library. Local timeshift buffering, XMLTV parser, this recording reader (which is very similar in concept to the timeshift buffer used in this addon) etc.

ksooo commented 4 years ago

That would be cool, yes.

Jalle19 commented 4 years ago

Noticed that AppVeyor integration is missing for this addon.

phunkyfish commented 4 years ago

Ya, I’ve been thinking the same. I’ve always wanted to build a proper circular buffer (memory/disk) for time shifting. One day.

Jalle19 commented 4 years ago

Ya, I’ve been thinking the same. I’ve always wanted to build a proper circular buffer (memory/disk) for time shifting. One day.

Yeah, that's one of the major limitations of this addon's current implementation (no circularity)

phunkyfish commented 4 years ago

I can add appveyor too.