search

kodi-pvr / pvr.vbox

Kodi VBox TV Gateway PVR addon
GNU General Public License v2.0
4 stars 22 forks source link

Timeshift buffer should use rolling files #35

Open Jalle19 opened 9 years ago

Jalle19 commented 9 years ago

This to avoid consuming all available disk space if a channel is left playing for too long.

mathiasslawik commented 6 years ago

Hello,

I'm using pvr.vbox on an NVidia Shield (Android TV) and it's working great!

However, when watching TV for a long time or forgetting to stop the stream before turning off the monitor, the buffer fills the whole file system, resulting in a nagging notification by the system that the internal storage is full.

Could it be maybe possible to use a ringbuffer for the purpose of timeshifting? In that case, the user could provide a maximum size and the buffer would "roll over" when the size is reached.

Maybe this ringbuffer implementation from the VDR project could be quite helpful in this regard. In VDR timeshifting works exactly as mentioned:

https://github.com/yavdr/vdr/blob/master/ringbuffer.c

I'm not proficient enough in C/C++ to contribute the code by myself, sorry. Would it be possible for you to implement such functionality sometime in the future?

Best regards, Mathias