Better error handling when manual bandwidth is used and no stream found

kodi-svtplay / xbmc-svtplay

Unofficial addon for watching SVT Play on Kodi

GNU General Public License v3.0

66 stars 34 forks source link

Better error handling when manual bandwidth is used and no stream found #210

Closed linqcan closed 5 years ago

linqcan commented 7 years ago

Currently the user gets a cryptic crash/error message from Kodi.

Proposal: Add a dialog stating why the stream couldn't start if manual bandwidth selection is used and no stream was found.

even-stephen commented 7 years ago

Maybe just have "low, medium, high" option and have logic to pick what stream that should be used? (instead of specifying a specific bitrate (which is subject to change)).

An error dialog would then not be needed.

linqcan commented 6 years ago

Note to future me: Consider refactoring the manual bandwidth functionality so that it could easier be removed in the future (as well as re-inserted if it is still used).

Background: The manual bandwidth feature was once created for Apple TV (ATV) as it could not handle the high def streams at some point in time. Kodi on ATV is now dead.

linqcan commented 5 years ago

Closing as this feature is removed in v5.0.2