search

kodi-svtplay / xbmc-svtplay

Unofficial addon for watching SVT Play on Kodi
GNU General Public License v3.0
67 stars 34 forks source link

Starting a program from the favorites menu has odd effects on "resume" and "information" #289

Closed andreas1974 closed 1 year ago

andreas1974 commented 1 year ago

Problem description

Starting a program from the Favourites menu results in missing information and resume does not work (the program starts from 00:00 even after selecting to resume at "20:35" (the question to resume shows up).

Steps to reproduce

[image1] DSCF6420

[image2] DSCF6422

[image3] DSCF6423

[image4] DSCF6421

System information

Kodi version: 18.9

Platform: LibreElec 9.2.8

Plugin version: 5.1.20

Log

linqcan commented 1 year ago

Thanks for reporting!

Will look into this, though it will have to wait a bit.

dobbelina commented 1 year ago

I miss the description on "Senaste/Latest programs" as can be seen below: image and image

linqcan commented 1 year ago

I miss the description on "Senaste/Latest programs" as can be seen below: image and image

@dobbelina are you sure you are running v5.1.20?

dobbelina commented 1 year ago

Yes i am. kodi 20.2 Windows image

andreas1974 commented 1 year ago

This may not be the same issue as the one I described in this thread about differences when starting a program from the Kodi favourites list. But anyway @dobbelina is right. It's the same on my Raspberry. However, when selecting the title from a search, the long description is showing. latest DSCF6433

linqcan commented 1 year ago

This is unfortunately how the API looks now for listings in sections like this one. What you are comparing with in one of the pictures is the details modal which is another API endpoint. The available information is what you see in Kodi and what can be seen in the background of your screenshot.

Regarding how it differs with search, that's because the API response is different there (you can this in the web app how listings differs between the two.)

Historically, this is how it's always been, data available in responses come and go depending on what they need in the web app. Can't do much about that. And in this specific case I don't want to do extra API calls to get the data as that would make the browsing experience much slower.

Hope this explains what you are experiencing.

dobbelina commented 1 year ago

To not slow down with extra api calls for recent on all the items listed, couldn't one make the api call individually when you hit the i(info) button? It would be similar as when you hoover over the program in the browser and get that terrible looking pop-up. (SVT webpage is terrible b.t.w) Having to go thru the hoop of doing a search to get this info is not optimal. Not even if i go thru categories=>Filmer do i get a proper listing.

linqcan commented 1 year ago

To not slow down with extra api calls for recent on all the items listed, couldn't one make the api call individually when you hit the i button? It would be similar as when you hoover over the program in the browser and get that terrible looking pop-up. (SVT webpage is terrible b.t.w)

Good idea though that is not possible for a Kodi addon. An addon only supply list item data to Kodi that Kodi then uses to populate the UI.

linqcan commented 1 year ago

@andreas1974 regarding the original issue

Starting a program from the Favourites menu results in missing information and resume does not work (the program starts from 00:00 even after selecting to resume at "20:35" (the question to resume shows up).

I looked into this and there is nothing I can do wrt this. I don't know why Kodi can resume a stream from the listing but not from favourites. Sorry!

andreas1974 commented 1 year ago

Were you able to repeat the error in your environment?

I note that a year ago Scott967 wrote this: The problem appears to be that plugin items that are added to favorites, and launched from the favorites dialog, don't pass resume point or other item metadata to the player. https://forum.kodi.tv/showthread.php?tid=369537

He also has a link to Imugr that shows a video describing the exact same behaviour: https://imgur.com/a/bamXedL

The Kodi developers may not have taken notice?

Thanks anyway for trying!

linqcan commented 1 year ago

Favorites is a native Kodi feature. The addon doesn't pass any data actively to Kodi for this, nor am I aware of any way of doing so. The issue you referred to seemed to speculate mostly about what could be the cause (?). I'd recommend you to post an issue in the Kodi forums as it might be a more general issue?

andreas1974 commented 1 year ago

I'll may try that. But I'd like to know whether it's a repeatable error, that you also were able to reproduce.

linqcan commented 1 year ago

I can reproduce it on my Windows machine with Kodi 19

andreas1974 commented 12 months ago

Hi again!

I sent the question to the Kodi add-ons forum. Would you have a look at https://forum.kodi.tv/showthread.php?tid=374491&pid=3166838#pid3166838 (have a look at jepsizofye at 18:05)

I'm not sure if the ones who answer realize that the resume time is showing up correctly (I've pointed it out at least twice). Perhaps there is more to it.

I don't understand all of it.

Andreas

linqcan commented 12 months ago

@andreas1974 thanks for digging into this. I still don't understand why an addon would need to go through all the trouble they are suggesting given that resume works when you play the item from within the addon. To me, that's a Kodi bug. I will look at the information again at later and try to understand if there is something indeed I can do or if I should file a Kodi issue for it. Thanks again!

andreas1974 commented 12 months ago

[jepsizofye] added some sample code today. (https://forum.kodi.tv/member.php?action=profile&uid=477027) If it doesn't fully describe what's missing for "favourites resume" to work even though it works from within the plugin, I suggest you send him a question in that same thread. He seems to be a very helpful guy!

matthuisman commented 11 months ago

Found the issue. its a bug in Kodi I think

There is a workaround: https://forum.kodi.tv/showthread.php?tid=374491&pid=3167591#pid3167591

linqcan commented 11 months ago

Found the issue. its a bug in Kodi I think

There is a workaround: https://forum.kodi.tv/showthread.php?tid=374491&pid=3167591#pid3167591

Thanks for letting me know! 🙏 I'll might look into the Kodi bug to see if I can do something to solve it there for real.