search

kodie / moment-holiday

A Moment.js plugin for handling holidays. NO LONGER MAINTAINED (DEPRECATED)
MIT License
83 stars 86 forks source link

Added UK Locale file. #13

Closed SilentGamelan closed 7 years ago

SilentGamelan commented 7 years ago

Includes UK holidays, and definitions of UK Regions: EN - England SC - Scotland NI - Northern Ireland WL - Wales.

h3ct0rjs commented 7 years ago

Hi @SilentGamelan you will need to verify the ci checks . The correct version is at https://gist.github.com/h3ct0rjs/7cedd670d7522ee5e3b6db713973d5bc, edit the new file

SilentGamelan commented 7 years ago

hi @h3ct0rjs - sorry to be a pain, but want to double-check how to correct my error: should I copy the gist you linked into my local UK_locale file, commit, and submit another pull request?

I'm relatively new to github and trying to find my feet!

Thanks.

h3ct0rjs commented 7 years ago

@SilentGamelan Yeah, That's it, I've used jshint to check your errors. You can edit the commit https://github.com/kodie/moment-holiday/pull/13/commits/572c7eec5491c404dbbe69bba5e96136a99941e8