Lacking Webpack integration

[alex996]

The package cannot be imported in a Webpack setup: import moment from 'moment-holiday yields Error: Cannot find module ".". A require calls does not succeed either. Could you add support for Webpack?

P.S. Originally discovered in the context of create-react-app.

[alex996]

Tried import 'moment-holiday', it seems to work sparingly, depending on the webpack config. Any clues?

[almadsen]

Plus one for this. I'm trying to use this with react, won't work, getting lots of web pack related errors.

[AndrewLane]

Seeing this as well...

[thabelo]

Hey, this seems to be a huge problem for us using react can you please show us how to fix this. Thanks

[maxkohl88]

Running into this too. Great library, but can't use it due to incompatibility with Webpack.

[natefoundry]

Also ran into this trying to use in React App.

Is there a workaround?

[kgrosvenor]

Cant import

[anonet1]

Workaround is to go to node-modules (moment-holiday folder, file:moment-holiday.min.js) and replace: “undefined”==typeof require||nul===require||require.amd?this.moment:require(“moment”)

with this line:

require("moment")

[kgrosvenor]

@anetk we don't really want to modify node_modules as most of the time we delete this before we commit js projects

[alex996]

@kgrosvenor Fork the .min file to your project then, so you can fix the requires there.

[joeldenning]

I have created a fork that is usable via webpack: https://github.com/joeldenning/moment-holiday.

Installation:

npm install --save https://github.com/joeldenning/moment-holiday\#1.5.2-webpack.0

[jaketrimble]

@joeldenning thanks for the fork! Also you may want to update your documentation to:

yarn add joeldenning/moment-holiday\#1.5.2-webpack.0

per https://github.com/yarnpkg/yarn/issues/2083#issuecomment-525335592

Cheers!