search

koding / kite.js

Kite client in JavaScript
kite.koding.com
MIT License
75 stars 16 forks source link

Accept connection option to enable Kites through an existing connection #56

Closed usirin closed 7 years ago

usirin commented 7 years ago

Instead of using a transport option mentioned in #51 i decided to use a connection option as it fits better IMO.

usirin commented 7 years ago

One improvement we can make to this is to use Session objects to wrap given connection to match api parity for KiteServer as it's being passed a Session object when a connection happened as it can be seen here: https://github.com/koding/kite.js/blob/master/src/server/websocket/index.js#L15