koding / kite.js

Kite client in JavaScript
kite.koding.com
MIT License
75 stars 16 forks source link

Remove kontrol operations from KiteServer #59

Closed usirin closed 6 years ago

usirin commented 7 years ago

Fixes #49

usirin commented 7 years ago

This should probably go to v2 because this is clearly a breaking change. Should we merge this to master or 2 branch?

gokmen commented 7 years ago

I think we can merge this one right now because we are not using KiteServer in Koding codebase currently. And with current Kontrol all the existing implementation in KiteServer was already broken I believe.

gokmen commented 7 years ago

yep, the only usage that I found is here https://github.com/koding/koding/blob/master/node_modules_koding/bongo/lib/bongo.coffee#L659-L706 which I've disabled it earlier.