search

koding / kite

Micro-service framework in Go
https://godoc.org/github.com/koding/kite
MIT License
3.26k stars 300 forks source link

kontrol: expose handlers to let users customize methods #126

Closed fatih closed 9 years ago

fatih commented 9 years ago

This is needed so the certain methods can be altered/changed in a custom Kontrol implementation. Such as disabling authenticating or adding throttling.

cihangir commented 9 years ago

there was a problem with etcd (cluster was not up) on travis, i've rebuilt it

cihangir commented 9 years ago

there is a problem with ectd, can you please check?

fatih commented 9 years ago

Yeah problem is due:

https://github.com/coreos/etcd/blob/master/build http://stackoverflow.com/questions/2462317/bash-syntax-error-redirection-unexpected

Ubuntu uses dash, a substitution for bash which doesn't support <<<. It was introduced two days ago: https://github.com/coreos/etcd/commit/dd4317db434ba36c0b39c74fffee8cd6c9e0769f

mischief commented 9 years ago

@fatih please file a bug on the etcd repo. build script claims to use 'sh', but herestrings (<<<) are not sh.

fatih commented 9 years ago

@mischief thanks! I just did with: https://github.com/coreos/etcd/issues/3417

fatih commented 9 years ago

@cihangir this is ready now, I'm downloading the binaries directly right now instead of building from the sources.

cihangir commented 9 years ago

Thanks @fatih for looking for the root cause. IMO https://github.com/koding/kite/pull/126#issuecomment-136703850 is a good call

:+1: