search

koding / kite

Micro-service framework in Go
https://godoc.org/github.com/koding/kite
MIT License
3.26k stars 300 forks source link

kontrol: Added NewWithoutHandlers func #135

Closed leeola closed 8 years ago

leeola commented 8 years ago

To allow a library user to provide their own handlers, the NewWithoutHandlers function has been introduced. This creates a kontrol instance with the normal config, but without any default kontrol handlers. The user can then provide their own handlers, or the existing kontrol handlers, as they see fit.

cc @cihangir @fatih

fatih commented 8 years ago

LGTM

fatih commented 8 years ago

The tests are failing due Travis (because we have tests that opens multiple concurrent connections and Travis's docker infrastructure can't scope with it).

leeola commented 8 years ago

@fatih Any recommendation on what to do with the tests then?

cihangir commented 8 years ago

i am working on failing tests here https://github.com/koding/kite/pull/137

leeola commented 8 years ago

Rebased for #137 changes, /fingerscrossed