search

koding / kite

Micro-service framework in Go
https://godoc.org/github.com/koding/kite
MIT License
3.26k stars 300 forks source link

fix building examples #138

Closed rjeczalik closed 8 years ago

rjeczalik commented 8 years ago

Hey,

Running go build ./... fails with:

$ go build ./...
go build github.com/koding/kite/test: no buildable Go source files in /Users/rjeczalik/src/github.com/koding/kite/test
# github.com/koding/kite/examples/exp2-watch
examples/exp2-watch/exp2-watch.go:23: undefined: kite.Event
examples/exp2-watch/exp2-watch.go:28: k.WatchKites undefined (type *kite.Kite has no field or method WatchKites)
# github.com/koding/kite/examples/math
examples/math/math.go:27: r.Response undefined (type *kite.Request has no field or method Response)

This CL tries to fix that problem. I took opportunity and extended the math example to be a bit more interactive.

fatih commented 8 years ago

Hi @rjeczalik.

Thanks for the PR

Etcd is not supported anymore with Go 1.3. I think we should not support it either. @rjeczalik can you please remove it from wercker.yml? @cihangir Any objections for it?

rjeczalik commented 8 years ago

@fatih Do you want to keep testing go1.3 with postgres or removing it altogether is ok?

fatih commented 8 years ago

I want to remove it altogether. People now use mostly 1.4.x and 1.5.x Also I think we shouldn't support that much version with our current man power :)

rjeczalik commented 8 years ago

@fatih Ack, then done. Please take a look :)

cihangir commented 8 years ago

https://github.com/koding/kite/pull/138#issuecomment-145274308

:+1:

rjeczalik commented 8 years ago

@fatih Renamed the receivers, PTAL.