search

koding / kite

Micro-service framework in Go
https://godoc.org/github.com/koding/kite
MIT License
3.26k stars 300 forks source link

config: add NewFromKiteKey #153

Closed rjeczalik closed 8 years ago

sent-hil commented 8 years ago

@rjeczalik what's the reason for this?

rjeczalik commented 8 years ago

@sent-hil To read /etc/kite.key without os.Putenv("KITE_HOME", "/etc/kite.key"); kitekey.Parse().

sent-hil commented 8 years ago

LGTM, can merge when tests pass

rjeczalik commented 8 years ago

The failure on master is caused by etcd using API from go1.5 - os.LookupEnv, needs to be pinned to 1.4-compatible release,

sent-hil commented 8 years ago

@rjeczalik could you do that when you get the chance please or can I merge it before that and not break anything?