search

koding / multiconfig

Load configuration from multiple sources in Go
http://godoc.org/github.com/koding/multiconfig
MIT License
454 stars 64 forks source link

Part of #23 - allow flagloader to set optional function to set flag usage #35

Closed client9 closed 9 years ago

client9 commented 9 years ago

@fatih This allow people to have function to set flag default Usage messages. To write a test I had to save the temporary FlagSet that is created (as a private field in FlagLoader). If you don't like this, we can either just delete the test (not great) or figure out another way to emit the usage and capture stdout/stderr (really gross).

merge, comment or suggestions all welcome!

n

fatih commented 9 years ago

Thanks @client9, nice addition :+1:

I've made comments, once they are fixed this is good to go.

client9 commented 9 years ago

hello @fatih good review. I made all the changes requested. Take a look!

fatih commented 9 years ago

LGTM.

fatih commented 9 years ago

Thanks @client9 for this addition, it'll make the flag loader more powerful. Much appreciated :)