search

koding / tunnel

Tunnel proxy package in Go
BSD 3-Clause "New" or "Revised" License
314 stars 70 forks source link

TMS-2128 support for TCP tunnels #12

Closed rjeczalik closed 8 years ago

rjeczalik commented 8 years ago

This CL adds support for TCP tunnels, with support for either port-based or IP-based routing.

cihangir commented 8 years ago

hi @rjeczalik can you please send refactoring and implementation in two PRs, since this is an important feature, lets not have interesting stuff to sneak in :)

rjeczalik commented 8 years ago

@cihangir Done. In another PR I'm going to send tests + refactoring. There may be still old flakes in tests (like https://travis-ci.org/koding/tunnel/jobs/113488281), I'll take them down after both PR are merged.

rjeczalik commented 8 years ago

The failure here is an old flake - we're not waiting in tests for the yamux session to get established before issuing http requests (partially workarounded in some tests). Will get that fixed in separate PR.

cihangir commented 8 years ago

there are two points that are not clear for me yet but, will check second pr with tests before commenting on them :)

cihangir commented 8 years ago

:+1: