Open LuciaCL opened 5 years ago
@wensug @Banjer71 @luiss6 @kinolag Take a look in the doc and tell me if is enough or if you wanna change something.
Hi Lucia,
thank you for putting the doc together. It's very helpful!
After a first run through I have few comments/questions:
i see the onClick effect which brings to the login page repeated for most of the pages. Other than the instance when we click on the login link I don't think we would need that elsewhere, considering that we are not creating logins. But I might have misunderstood what your idea is :)
regarding page 10 - we might want to think if we prefer to require the user to receive an invitation to the event, or alternatively, giving him the possibility to view all the events planned for his group and decide which ones to join. As a minor detail, in the form, in case of a passenger, we might want enable the option "how many people are travelling with you"? Just a minor detail :)
finally, in case we decide to reduce, at least initially, the complexity of the various permutations, we might remove the group layer and assume the people all part of the same group. I agree that groups would make total sense, but just something we can bear in mind should run out of time.
Thanks again for this documentation :)
Luigi
On Wed, May 15, 2019 at 2:52 PM LuciaCL notifications@github.com wrote:
@wensug https://github.com/wensug @Banjer71 https://github.com/Banjer71 @luiss6 https://github.com/luiss6 @kinolag https://github.com/kinolag Take a look in the doc and tell me if is enough or if you wanna change something.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kodiri/carru/issues/20?email_source=notifications&email_token=AKWYNVXK4EEDWRQKYEZEZDDPVQIRPA5CNFSM4HMLLD22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOXH2I#issuecomment-492663785, or mute the thread https://github.com/notifications/unsubscribe-auth/AKWYNVQXPJPD32MN33QK5HLPVQIRPANCNFSM4HMLLD2Q .
Hi Luigi! I am going to answering in the same order of your comments.
-And the group thing. We can speak about that. I was thinking that we can have the screen done... do first without the group and then, if we have enough time, we can implement that...
Thanks for your comments 👍
perfect! Many thanks Lucia. See you tomorrow
Luigi
On Wed, May 15, 2019 at 3:54 PM LuciaCL notifications@github.com wrote:
Hi Luigi! I am going to answering in the same order of your comments.
- Yes, you are right... It is just a problem with copy/paste. The Login should dissapear ones your are logged in. and maybe we can change for the user name and do a link to the dashboard. But yes, you are right :) -With the invitation to the event. I was thinking in put, on the dashboard a new small box like 'you have a new event' and then that screen appears. I think your question is ok. We need to speak about the text.... o all the screens ;)
-And the group thing. We can speak about that. I was thinking that we can have the screen done... do first without the group and then, if we have enough time, we can implement that...
Thanks for your comments 👍
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kodiri/carru/issues/20?email_source=notifications&email_token=AKWYNVWSUI2PCBSUT6ANWITPVQP2PA5CNFSM4HMLLD22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVO5TSA#issuecomment-492689864, or mute the thread https://github.com/notifications/unsubscribe-auth/AKWYNVRXCOCX7X37DLAIJGDPVQP2PANCNFSM4HMLLD2Q .
Basic guidance about the app, and the organisation of the components.