Closed resolritter closed 3 months ago
MangaClash 0.0.85
English
The listings' chapters are loaded successfully
An exception is thrown while loading the listing's chapters:
0.1.85
Samsung Galaxy Tab A
This problem seems to happen because the madara source adds to 3 arrays independently in getDetail: chapUrls, chaptersNames and chapDates.
madara
getDetail
chapUrls
chaptersNames
chapDates
https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L184-L186
If those arrays somehow end up with different sizes, then an exception might be thrown later on due to incorrect indexing, presumably around here:
https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L242
I have refactored that part of the code locally and the problem apparently went away. I'll submit a PR for this later.
Source information
MangaClash 0.0.85
Source language
English
Steps to reproduce
Expected behavior
The listings' chapters are loaded successfully
Actual behavior
An exception is thrown while loading the listing's chapters:
Mangayomi version
0.1.85
Device
Samsung Galaxy Tab A
Other details
This problem seems to happen because the
madara
source adds to 3 arrays independently ingetDetail
:chapUrls
,chaptersNames
andchapDates
.https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L184-L186
If those arrays somehow end up with different sizes, then an exception might be thrown later on due to incorrect indexing, presumably around here:
https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L242
I have refactored that part of the code locally and the problem apparently went away. I'll submit a PR for this later.
Acknowledgements