search

kodus / mail

Simple, modern library of services for sending UTF-8 e-mail
38 stars 5 forks source link

Add support for psr/log 2 and 3 #17

Closed sunkan closed 1 year ago

sunkan commented 1 year ago

Make it so I can use this package with never applications.

The only place this package actually implements anything from the log package is in SMTPClient and that code is still valid

thomasnordahl-dk commented 1 year ago

Thank you for the Pull Request.

Before we can merge this request, I would like to see the tests pass, which they currently are not. This is because of the MockLogger class in the tests, that implements the LoggerInterface - it would need to have the new type hints added before the tests will pass.

I'm not sure why the Github Actions and Scrutinizer are not running properly on the PR (I'll have to look into that at some point), but you can see the failing actions on your fork here: https://github.com/sunkan/kodus.mail/actions/runs/4342720240

Thanks again for the help - we don't have a lot of time to get through these issues in the Kodus group right now, so it is much appreciated. :+1:

sunkan commented 1 year ago

Thanks for the review and the quick new release