search

kodyl / stilr

Encapsulated styling for your javascript components with all the power of javascript and CSS combined.
MIT License
236 stars 16 forks source link

React shouldn't be a dependency #12

Closed KyleAMathews closed 7 years ago

KyleAMathews commented 9 years ago

React isn't needed for this module to work + including React as a dependency means under some conditions it'll get required twice which leads to weird bugs.

chriskjaer commented 9 years ago

Yeah, ideally React shouldn't be a dependency but Stilr uses Reacts internal helper lib to convert js objects to css. (See https://github.com/kodyl/stilr/blob/master/lib/utils.js#L1). But if we just extract that we should be good.

KyleAMathews commented 9 years ago

:+1:

KyleAMathews commented 9 years ago

Perhaps to a standalone module.

chriskjaer commented 9 years ago

Definitely a standalone module. I might have some time to look into it soon. Unless you're up for it?

KyleAMathews commented 9 years ago

Super busy with startup + other open source work... wouldn't get to this for a while. On Tue, Jul 21, 2015 at 1:08 PM Chris Kjær notifications@github.com wrote:

Definitely a standalone module. I might have some time to look into it soon. Unless you're up for it?

— Reply to this email directly or view it on GitHub https://github.com/kodyl/stilr/pull/12#issuecomment-123463388.

ericelliott commented 9 years ago

React .14 did some module splitting... Has anybody looked at this since then?

ericelliott commented 9 years ago

BTW, Huge +1 here. I wouldn't deploy this to prod until this is handled. Multiple React instances have caused lots of trouble for people.

tychota commented 9 years ago

+1 too ! I can't use it with npm since im on react 0.14, so i must copy source and manually change for react 0.14

webpapaya commented 8 years ago

I think we can close this on in favor of #31

danieljuhl commented 8 years ago

@webPapaya I'll have a look at your various pull requests and issues, and see if we can cut a beta release without React.

danieljuhl commented 7 years ago

stilr@1.3.0 has just been released, and doesn't depend on react