kodyl / stilr

Encapsulated styling for your javascript components with all the power of javascript and CSS combined.
MIT License
236 stars 16 forks source link

Remove `babel-eslint`and `eslint-plugin-react` as a dependency #32

Closed webpapaya closed 8 years ago

webpapaya commented 8 years ago

This PR removes two dependencies from the stilr:

ESLint allows custom parsers. This is great but some of the syntax nodes that Babel supports aren't supported by ESLint. When using this plugin, ESLint is monkeypatched and your code is transformed into code that ESLint can understand. All location info such as line numbers, columns is also retained so you can track down errors with ease. (https://github.com/babel/babel-eslint#how-does-it-work)

I think since version 2 of eslint they have a good support for the new es6 syntax. As stilr is currently not using any syntax which isn't supported by the eslint default parser, we should remove babel-eslint for now. We can think about reenable it if somebody want's to use a new and fancy js syntax which is currently not supported by eslint.

Why remove eslint-plugin-react

While reading through the list of supported rules of eslint-plugin-react I realized that all of the rules are very react/jsx centric. As stilr is not using any jsx or react we can safely remove eslint-plugin-react.

danieljuhl commented 8 years ago

You are completely right, and thanks again for your great contribution. It is very much appreciated.