koel / docker

A minimal docker image for the koel music streaming server.
https://hub.docker.com/r/phanan/koel/
MIT License
178 stars 54 forks source link

can't connetct last.fm #62

Closed kroyoo closed 3 years ago

kroyoo commented 3 years ago

i see this: https://docs.koel.dev/3rd-party.html#last-fm my configuration APP_ENV=production APP_DEBUG=false APP_URL=https://koel.fungit.org/ ADMIN_NAME="Fungit" ADMIN_EMAIL=koel@fungit.org ADMIN_PASSWORD=1234566 APP_MAX_SCAN_TIME=600 MEMORY_LIMIT= FORCE_HTTPS=true LASTFM_API_KEY=9518c0b4b58b6adf5dceaebb2de40b56 LASTFM_API_SECRET=766d2fef444af4532f1e76f9f901f7f4 ALLOW_DOWNLOAD=true when i click connect button in profile . Whenever I change the API and key, it will be redirected to this address. https://koel.fungit.org/web/lastfm/connect?api_token=1|t2JSsj2RUEMIoGy4vBHXTq9JZPT1KgNeQug30bT2, this token Never change. This https://koel.fungit.org/web/lastfm URL also not found.

image

i try to fill homepage url or not, But it's the same thing

kroyoo commented 3 years ago

and can't generate JWT_SECRET image

kroyoo commented 3 years ago

i see this: https://docs.koel.dev/3rd-party.html#last-fm my configuration APP_ENV=production APP_DEBUG=false APP_URL=https://koel.fungit.org/ ADMIN_NAME="Fungit" ADMIN_EMAIL=koel@fungit.org ADMIN_PASSWORD=1234566 APP_MAX_SCAN_TIME=600 MEMORY_LIMIT= FORCE_HTTPS=true LASTFM_API_KEY=<REDACTED> LASTFM_API_SECRET=<REDACTED> ALLOW_DOWNLOAD=true when i click connect button in profile . Whenever I change the API and key, it will be redirected to this address. https://koel.fungit.org/web/lastfm/connect?api_token=1|t2JSsj2RUEMIoGy4vBHXTq9JZPT1KgNeQug30bT2, this token Never change. This https://koel.fungit.org/web/lastfm URL also not found.

image

i try to fill homepage url or not, But it's the same thing

I find that the correct URL is "domain/lastfm/connect?api_token", not "domain/web/lastfm/connect?api_token''

image image

Hyzual commented 3 years ago

Hi, were you able to do the lastfm integration ? From the last screenshot it looks like it worked

and can't generate JWT_SECRET

It is expected, since v5.0.0 of Koel there is no more JWT secret, so there is no longer a command to generate one.

kroyoo commented 3 years ago

Hi, were you able to do the lastfm integration ? From the last screenshot it looks like it worked

and can't generate JWT_SECRET

It is expected, since v5.0.0 of Koel there is no more JWT secret, so there is no longer a command to generate one. I find that the correct URL is "domain/lastfm/connect?api_token", not "domain/web/lastfm/connect?api_token''. The default URL is wrong("/web/lastfm/connect?api_token") . I need to use this address("/lastfm/connect?api_token") to connect to Last.fm

Hyzual commented 3 years ago

I could reproduce on a new installation. Indeed, the redirect URL with /web/lastfm is wrong and leads to 404. Unfortunately it looks like I cannot help you further :confused:. I am not maintainer of koel, I only build the docker image. Would you please open an issue at https://github.com/koel/koel/issues so that the maintainers of Koel can change the redirect URL and fix the Lastfm integration ?

Also a side note: It looks like you have leaked your lastfm API key and secret in this message. I replaced them by <REDACTED> but you should revoke this key and create a new one. Anyone that has read this issue before could use the Lastfm API and impersonate you.

kroyoo commented 3 years ago

OK, thanks for your test. I also use the Docker version, and I'm not sure if there is any problem with the official compiled version.