search

koenbeuk / EntityFrameworkCore.Triggered

Triggers for EFCore. Respond to changes in your DbContext before and after they are committed to the database.
MIT License
554 stars 29 forks source link

Scoped Dependency Issue #156

Closed anthony-keller closed 1 year ago

anthony-keller commented 2 years ago

This issue may prove tricky to repro, so I'll explain the issue and you can advise on further action.

This image shows some logs containing the HttpContext TraceIdentifier, the DbContext Id and a Guid in a scoped dependency RequestAuthVariables.

image

The highlighted rows show that two different HttpContexts get the same instance of RequestAuthVariables.

This is an intermittent issue in our production system and we've been able to reproduce in an integration test using a Parallel.ForEachAsync loop of 100. A loop of 10 typically works correctly and even the loop of 100 occasionally works.

Our interim solution is to register our triggers as Transient instead of Scoped.

We're using the AddTriggeredDbContextPool and AddTriggeredPooledDbContextFactory

@benmccallum and I are happy to try and work with you as needed.

koenbeuk commented 2 years ago

@anthony-keller Haven't had a chance to look into this yet, will have more time in the coming weeks. If you have a repro, that would be super useful! I tried to recreate this issue once without success.

anthony-keller commented 2 years ago

@koenbeuk I can repro in our codebase so perhaps at some point we could jump on a Zoom/Meet/Teams to debug. I'm in GMT+10:00

koenbeuk commented 2 years ago

@anthony-keller Happy to do so, please sent me a ping at redacted so that we can arrange a time and virtual place. Thanks!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

koenbeuk commented 1 year ago

We found a memory leak issue in #168 that may have caused this issue. We should test if this is still an issue after updating to v3.2.2

anthony-keller commented 1 year ago

I did report a potential regression on the pr about 30 mins ago

anthony-keller commented 1 year ago

I'll test this issue as well

anthony-keller commented 1 year ago

I'm still table to reproduce this issue on 3.2.2.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.